Remove redundant tests and comments for OM creation

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

Author: vesari

expfmt/openmetrics_create.go

@@ -50,8 +50,6 @@ func WithCreatedLines() EncoderOption {
 	}
 }
 
-
-
 // MetricFamilyToOpenMetrics converts a MetricFamily proto message into the
 // OpenMetrics text format and writes the resulting lines to 'out'. It returns
 // the number of bytes written and any error encountered. The output will have
@@ -89,15 +87,6 @@ func WithCreatedLines() EncoderOption {
 //     its type will be set to `unknown` in that case to avoid invalid OpenMetrics
 //     output.
 //
-//   - According to the OM specs, the `# UNIT` line is optional, but if populated,
-//     the unit has to be present in the metric name as its suffix:
-//     (see https://github.com/prometheus/OpenMetrics/blob/v1.0.0/specification/OpenMetrics.md#unit).
-//     However, in order to accommodate any potential scenario where such a change in the
-//     metric name is not desirable, the users are here given the choice of either explicitly
-//     opt in, in case they wish for the unit to be included in the output AND in the metric name
-//     as a suffix (see the description of the WithUnit function above),
-//     or not to opt in, in case they don't want for any of that to happen.
-//
 //   - No support for the following (optional) features: info type,
 //     stateset type, gaugehistogram type.
 //
@@ -141,7 +130,6 @@ func MetricFamilyToOpenMetrics(out io.Writer, in *dto.MetricFamily, options ...E
 	if metricType == dto.MetricType_COUNTER && strings.HasSuffix(compliantName, "_total") {
 		compliantName = name[:len(name)-6]
 	}
-	
 
 	// Comments, first HELP, then TYPE.
 	if in.Help != nil {

expfmt/openmetrics_create_test.go

@@ -619,7 +619,7 @@ foos_total 42.0
 # UNIT name_seconds seconds
 `,
 		},
-		// 15: Histogram plus unit, but unit not opted in.
+		// 15: Histogram plus unit
 		{
 			in: &dto.MetricFamily{
 				Name: proto.String("request_duration_microseconds"),
@@ -669,33 +669,7 @@ request_duration_microseconds_sum 1.7560473e+06
 request_duration_microseconds_count 2693
 `,
 		},
-		// 16: No metric, unit opted in, no unit in name.
-		{
-			in: &dto.MetricFamily{
-				Name:   proto.String("name_total"),
-				Help:   proto.String("doc string"),
-				Type:   dto.MetricType_COUNTER.Enum(),
-				Unit:   proto.String("seconds"),
-				Metric: []*dto.Metric{},
-			},
-			out: `# HELP name doc string
-# TYPE name counter
-# UNIT name seconds
-`,
-		},
-		// 17: No metric, unit opted in, BUT unit == nil.
-		{
-			in: &dto.MetricFamily{
-				Name:   proto.String("name_total"),
-				Help:   proto.String("doc string"),
-				Type:   dto.MetricType_COUNTER.Enum(),
-				Metric: []*dto.Metric{},
-			},
-			out: `# HELP name doc string
-# TYPE name counter
-`,
-		},
-		// 18: Counter, timestamp given, unit opted in, _total suffix.
+		// 16: Counter, timestamp given, unit given, _total suffix.
 		{
 			in: &dto.MetricFamily{
 				Name: proto.String("some_measure_total"),
@@ -743,7 +717,7 @@ some_measure_total{labelname="val1",basename="basevalue"} 42.0
 some_measure_total{labelname="val2",basename="basevalue"} 0.23 1.23456789e+06
 `,
 		},
-		// 11: Gauge histogram.
+		// 17: Gauge histogram.
 		{
 			in: &dto.MetricFamily{
 				Name: proto.String("name"),