Skip to content

Pronto and syntax errors #86

Description

@renatolond

Using ruby 2.7.x, if I create a syntax error, rubocop reports it at the end of the file:

Inspecting 1 file
E

Offenses:

config.ru:179:1: E: Lint/Syntax: unexpected token $end
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)

1 file inspected, 1 offense detected

However, the error was introduced in a previous line.
This means that if we're running rubocop directly, we would see that this file is not parseable, but using pronto there's no complaints (this flies under the radar in a CI check, for instance).

Would it make sense that pronto always reports Syntax errors on touched files, even outside of the patch zone?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions