Skip to content

Commit 6973cfa

Browse files
Restrict wildcard redirect URIs in realm configuration (#2)
Wildcard redirect URIs allow open redirect attacks where an attacker can craft a login URL that redirects the auth code/token to a domain they control. This tightens the redirect URIs for all clients: - Icatx_application: /* -> http://webprotege-local.edu/* - machine-client: * -> [] (service-account-only, no redirect needed) - user-management: /* -> [] (service-account-only, no redirect needed) - webprotege: removed redundant/double-wildcard entries, kept single explicit pattern
1 parent 8b3c9e4 commit 6973cfa

1 file changed

Lines changed: 7 additions & 16 deletions

File tree

webprotege.json

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -618,10 +618,10 @@
618618
"clientAuthenticatorType": "client-secret",
619619
"secret": "**********",
620620
"redirectUris": [
621-
"/*"
621+
"http://webprotege-local.edu/*"
622622
],
623623
"webOrigins": [
624-
"/*"
624+
"http://webprotege-local.edu"
625625
],
626626
"notBefore": 0,
627627
"bearerOnly": false,
@@ -943,9 +943,7 @@
943943
"alwaysDisplayInConsole": false,
944944
"clientAuthenticatorType": "client-secret",
945945
"secret": "**********",
946-
"redirectUris": [
947-
"*"
948-
],
946+
"redirectUris": [],
949947
"webOrigins": [],
950948
"notBefore": 0,
951949
"bearerOnly": false,
@@ -1168,12 +1166,8 @@
11681166
"alwaysDisplayInConsole": false,
11691167
"clientAuthenticatorType": "client-secret",
11701168
"secret": "**********",
1171-
"redirectUris": [
1172-
"/*"
1173-
],
1174-
"webOrigins": [
1175-
"/*"
1176-
],
1169+
"redirectUris": [],
1170+
"webOrigins": [],
11771171
"notBefore": 0,
11781172
"bearerOnly": false,
11791173
"consentRequired": false,
@@ -1238,13 +1232,10 @@
12381232
"alwaysDisplayInConsole": true,
12391233
"clientAuthenticatorType": "client-secret",
12401234
"redirectUris": [
1241-
"http://webprotege-local.edu/*",
1242-
"http://webprotege-local.edu*",
1243-
"http://webprotege-local.edu**",
1244-
"http://webprotege-local.edu/webprotege/*"
1235+
"http://webprotege-local.edu/*"
12451236
],
12461237
"webOrigins": [
1247-
"http://webprotege-local.edu/webprotege"
1238+
"http://webprotege-local.edu"
12481239
],
12491240
"notBefore": 0,
12501241
"bearerOnly": false,

0 commit comments

Comments
 (0)