-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Expand file tree
/
Copy pathedit-role-form.test.tsx
More file actions
418 lines (369 loc) · 11.9 KB
/
Copy pathedit-role-form.test.tsx
File metadata and controls
418 lines (369 loc) · 11.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
import { updateRole } from "@/actions/roles/roles";
import { EditRoleForm } from "./edit-role-form";
const routerMocks = vi.hoisted(() => ({
push: vi.fn(),
}));
vi.mock("next/navigation", () => ({
useRouter: () => routerMocks,
}));
vi.mock("@/actions/roles/roles", () => ({
updateRole: vi.fn(),
}));
vi.mock("@/lib", () => ({
cn: (...classes: Array<string | false | null | undefined>) =>
classes.filter(Boolean).join(" "),
getErrorMessage: (error: unknown) => String(error),
permissionFormFields: [
{
field: "manage_users",
label: "Invite and Manage Users",
description:
"Allows inviting new users and managing existing user details",
},
{
field: "manage_account",
label: "Manage Account",
description: "Provides access to account settings and RBAC configuration",
},
{
field: "unlimited_visibility",
label: "Unlimited Visibility",
description:
"Provides complete visibility across all the providers and its related resources",
},
{
field: "manage_providers",
label: "Manage Providers",
description:
"Allows configuration and management of provider connections",
},
{
field: "manage_integrations",
label: "Manage Integrations",
description:
"Allows configuration and management of third-party integrations",
},
{
field: "manage_scans",
label: "Manage Scans",
description: "Allows launching and configuring scans security scans",
},
{
field: "manage_alerts",
label: "Manage Alerts",
description: "Allows creating and managing custom alerts",
},
{
field: "manage_lighthouse_ai_configuration",
label: "Manage Lighthouse AI",
description:
"Allows configuring Lighthouse AI, including its provider credentials, default model and business context",
},
{
field: "manage_registry",
label: "Manage Registry",
description: "Allows managing tenant Registry credentials and artifacts",
},
{
field: "manage_billing",
label: "Manage Billing",
description: "Provides access to billing settings and invoices",
},
],
}));
vi.mock("@/components/shadcn/select/enhanced-multi-select", () => ({
EnhancedMultiSelect: () => <div data-testid="group-select" />,
}));
vi.mock("@/components/ui", () => ({
useToast: () => ({ toast: vi.fn() }),
}));
beforeAll(() => {
class ResizeObserverMock {
observe() {}
unobserve() {}
disconnect() {}
}
globalThis.ResizeObserver = ResizeObserverMock;
window.ResizeObserver = ResizeObserverMock;
});
const roleData = ({
manageProviders = false,
manageRegistry = false,
unlimitedVisibility = false,
}: {
manageProviders?: boolean;
manageRegistry?: boolean;
unlimitedVisibility?: boolean;
} = {}) => ({
data: {
attributes: {
name: "Existing role",
manage_users: false,
manage_account: false,
manage_providers: manageProviders,
manage_integrations: false,
manage_registry: manageRegistry,
manage_scans: false,
unlimited_visibility: unlimitedVisibility,
groups: [],
},
relationships: {
provider_groups: {
data: [],
},
},
},
});
const renderEditRoleForm = (options?: Parameters<typeof roleData>[0]) =>
render(
<EditRoleForm roleId="role-1" roleData={roleData(options)} groups={[]} />,
);
const submittedFormData = () => {
const formData = vi.mocked(updateRole).mock.calls.at(-1)?.[0];
if (!formData) throw new Error("updateRole was not called");
return formData;
};
describe("EditRoleForm", () => {
afterEach(() => {
routerMocks.push.mockClear();
vi.mocked(updateRole).mockClear();
vi.unstubAllEnvs();
});
it("retains manage_registry when updating a role in Prowler Cloud", async () => {
// Given
vi.stubEnv("UI_CLOUD_ENABLED", "true");
const user = userEvent.setup();
renderEditRoleForm({ manageRegistry: true });
// When
await user.click(screen.getByRole("button", { name: "Update Role" }));
// Then
expect(submittedFormData().get("manage_registry")).toBe("true");
});
it("submits manage_lighthouse_ai_configuration when granted in Prowler Cloud", async () => {
// Given
vi.stubEnv("UI_CLOUD_ENABLED", "true");
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(
screen.getByRole("checkbox", { name: "Manage Lighthouse AI" }),
);
await user.click(screen.getByRole("button", { name: "Update Role" }));
// Then
expect(submittedFormData().get("manage_lighthouse_ai_configuration")).toBe(
"true",
);
expect(vi.mocked(updateRole).mock.calls.at(-1)?.[1]).toBe("role-1");
});
it("submits manage_lighthouse_ai_configuration as false when not granted in Prowler Cloud", async () => {
// Given
vi.stubEnv("UI_CLOUD_ENABLED", "true");
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(screen.getByRole("button", { name: "Update Role" }));
// Then
expect(submittedFormData().get("manage_lighthouse_ai_configuration")).toBe(
"false",
);
});
it("omits manage_lighthouse_ai_configuration from the submission outside Prowler Cloud", async () => {
// Given
vi.stubEnv("UI_CLOUD_ENABLED", "false");
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(screen.getByRole("button", { name: "Update Role" }));
// Then
expect(submittedFormData().has("manage_lighthouse_ai_configuration")).toBe(
false,
);
expect(submittedFormData().has("manage_registry")).toBe(false);
});
it("shows the subtle Unlimited Visibility description inside Visibility", () => {
// Given / When
renderEditRoleForm();
// Then
expect(screen.queryByRole("alert")).not.toBeInTheDocument();
expect(
screen.getByText(
"Checking the box below grants visibility into every provider: resources, findings, scans, and compliance results, regardless of the provider groups selected.",
),
).toBeInTheDocument();
expect(
screen.getByText(/required to use the Jira integration/i),
).toHaveProperty("tagName", "STRONG");
expect(
screen.getByRole("link", { name: /learn more about provider groups/i }),
).toHaveAttribute(
"href",
"https://docs.prowler.com/user-guide/tutorials/prowler-app-rbac#provider-groups",
);
expect(
screen.queryByText(
/manage providers enables unlimited visibility in this form because provider administration needs organization-wide provider-group context/i,
),
).not.toBeInTheDocument();
const visibilityHeading = screen.getByText("Visibility");
const unlimitedVisibilityCheckbox = screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
});
expect(
visibilityHeading.compareDocumentPosition(unlimitedVisibilityCheckbox) &
Node.DOCUMENT_POSITION_FOLLOWING,
).toBeTruthy();
});
it("keeps the Visibility section and hides only groups when Unlimited Visibility is enabled", async () => {
// Given
const user = userEvent.setup();
render(
<EditRoleForm
roleId="role-1"
roleData={roleData()}
groups={[{ id: "group-1", name: "Production" }]}
/>,
);
// When
await user.click(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
);
// Then
expect(screen.getByText("Visibility")).toBeInTheDocument();
expect(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
).toBeChecked();
expect(
screen.getByText(/checking the box below grants visibility/i),
).toBeInTheDocument();
expect(screen.queryByTestId("group-select")).not.toBeInTheDocument();
expect(
screen.queryByText(/select the groups this role will have access to/i),
).not.toBeInTheDocument();
});
it("does not force Unlimited Visibility when Manage Providers is selected", async () => {
// Given
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(
screen.getByRole("checkbox", { name: "Manage Providers" }),
);
// Then
expect(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
).not.toBeChecked();
expect(
screen.queryByText(
/Manage Providers is selected, so Unlimited Visibility stays enabled in this form/i,
),
).not.toBeInTheDocument();
});
it("does not force Unlimited Visibility when granting all admin permissions", async () => {
// Given
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(
screen.getByRole("checkbox", { name: "Grant all admin permissions" }),
);
// Then
expect(
screen.getByRole("checkbox", { name: "Manage Providers" }),
).toBeChecked();
expect(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
).not.toBeChecked();
});
it("keeps Unlimited Visibility user-controlled when Manage Providers is selected", async () => {
// Given
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(
screen.getByRole("checkbox", { name: "Manage Providers" }),
);
await user.click(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
);
await user.click(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
);
// Then
expect(
screen.getByRole("checkbox", { name: "Manage Providers" }),
).toBeChecked();
expect(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
).not.toBeChecked();
expect(screen.getByTestId("group-select")).toBeInTheDocument();
});
it("keeps explicitly enabled Unlimited Visibility when all admin permissions are toggled off", async () => {
// Given
const user = userEvent.setup();
renderEditRoleForm();
// When
await user.click(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
);
await user.click(
screen.getByRole("checkbox", { name: "Grant all admin permissions" }),
);
await user.click(
screen.getByRole("checkbox", { name: "Grant all admin permissions" }),
);
// Then
expect(
screen.getByRole("checkbox", { name: "Manage Providers" }),
).not.toBeChecked();
expect(
screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
}),
).toBeChecked();
});
it("does not show extra Manage Providers guidance", () => {
// Given / When
renderEditRoleForm({ manageProviders: true, unlimitedVisibility: true });
// Then
expect(
screen.queryByText(
/Manage Providers is selected, so Unlimited Visibility stays enabled in this form/i,
),
).not.toBeInTheDocument();
expect(
screen.queryByText(/remove this automatic visibility grant/i),
).not.toBeInTheDocument();
});
it("keeps existing inconsistent Manage Providers and Unlimited Visibility values on initial render", () => {
// Given / When
renderEditRoleForm({ manageProviders: true, unlimitedVisibility: false });
// Then
expect(
screen.getByRole("checkbox", { name: "Manage Providers" }),
).toBeChecked();
const unlimitedVisibilityCheckbox = screen.getByRole("checkbox", {
name: "Enable Unlimited Visibility for this role",
});
expect(unlimitedVisibilityCheckbox).not.toBeChecked();
expect(unlimitedVisibilityCheckbox).toBeEnabled();
});
});