fix(customers): guard nil billing/shipping address on customer show page (#29)

Imported customers (Bottle) have a shipping_address but no billing_address,
so the show page crashed with (KeyError) key :full_address not found in: nil
when rendering @customer.billing_address.full_address. Guard both addresses
with the same && idiom already used on the order invoice page.

Author: timchambers

lib/craftplan_web/live/manage/customer_live/show.ex

@@ -26,8 +26,12 @@ defmodule CraftplanWeb.CustomerLive.Show do
               <:item title="Name">{@customer.full_name}</:item>
               <:item title="Email">{@customer.email}</:item>
               <:item title="Phone">{@customer.phone}</:item>
-              <:item title="Billing Address">{@customer.billing_address.full_address}</:item>
-              <:item title="Shipping Address">{@customer.shipping_address.full_address}</:item>
+              <:item title="Billing Address">
+                {@customer.billing_address && @customer.billing_address.full_address}
+              </:item>
+              <:item title="Shipping Address">
+                {@customer.shipping_address && @customer.shipping_address.full_address}
+              </:item>
             </.list>
           </div>
         </div>

test/craftplan_web/manage_customers_live_test.exs

@@ -52,6 +52,28 @@ defmodule CraftplanWeb.ManageCustomersLiveTest do
       assert render(view) =~ c.first_name
     end
 
+    @tag role: :staff
+    test "renders details tab when billing_address is nil (imported customer)", %{conn: conn} do
+      # Bottle-imported customers have a shipping_address but no billing_address.
+      c =
+        Customer
+        |> Ash.Changeset.for_create(:create, %{
+          type: :individual,
+          first_name: "Imported",
+          last_name: "Buyer",
+          email: "imported+#{System.unique_integer([:positive])}@local",
+          shipping_address: %{street: "1 St", city: "DC", country: "US"}
+        })
+        |> Ash.create!()
+
+      assert is_nil(c.billing_address)
+
+      {:ok, view, _html} = live(conn, ~p"/manage/customers/#{c.reference}")
+      assert render(view) =~ "Imported"
+      assert render(view) =~ "Billing Address"
+      assert render(view) =~ "Shipping Address"
+    end
+
     @tag role: :staff
     test "renders orders and statistics tabs", %{conn: conn} do
       c = create_customer!()