Skip to content

Commit d722e39

Browse files
committed
fix: improve visible-overflow-no-resize test.html visual clarity
- Add background color to all warn and ok cases - Warn labels note "no resize handle" to explain the visual check - Ok labels note "resize handle visible in bottom-right corner" - Remove trivial resize:none ok case
1 parent 29f8087 commit d722e39

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

examples/test.html

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3736,68 +3736,70 @@ <h2>visible-overflow-no-resize: resize on visible overflow</h2>
37363736
<h3>Should warn</h3>
37373737
<div class="case expect-warn" data-rule="visible-overflow-no-resize">
37383738
<div class="label label-warn">
3739-
visible-overflow-no-resize warn: resize:both with default overflow (visible)
3739+
visible-overflow-no-resize warn: resize: both overflow is visible, no resize handle
37403740
</div>
3741-
<div data-target style="resize: both; width: 200px; height: 100px">
3742-
This div has resize: both but overflow is visible
3741+
<div data-target style="resize: both; width: 200px; height: 80px; background: #e8e8e8">
3742+
resize: both — no handle (overflow: visible)
37433743
</div>
37443744
</div>
37453745
<div class="case expect-warn" data-rule="visible-overflow-no-resize">
37463746
<div class="label label-warn">
3747-
visible-overflow-no-resize warn: resize:horizontal with default overflow (visible)
3747+
visible-overflow-no-resize warn: resize: horizontal overflow-x is visible, no handle
37483748
</div>
3749-
<div data-target style="resize: horizontal; width: 200px; height: 100px">
3750-
resize: horizontal needs overflow-x to be non-visible
3749+
<div data-target style="resize: horizontal; width: 200px; height: 80px; background: #e8e8e8">
3750+
resize: horizontal — no handle
37513751
</div>
37523752
</div>
37533753
<div class="case expect-warn" data-rule="visible-overflow-no-resize">
37543754
<div class="label label-warn">
3755-
visible-overflow-no-resize warn: resize:vertical with default overflow (visible)
3755+
visible-overflow-no-resize warn: resize: vertical overflow-y is visible, no handle
37563756
</div>
3757-
<div data-target style="resize: vertical; width: 200px; height: 100px">
3758-
resize: vertical needs overflow-y to be non-visible
3757+
<div data-target style="resize: vertical; width: 200px; height: 80px; background: #e8e8e8">
3758+
resize: vertical — no handle
37593759
</div>
37603760
</div>
37613761
<div class="case expect-warn" data-rule="visible-overflow-no-resize">
37623762
<div class="label label-warn">
3763-
visible-overflow-no-resize warn: resize:both with overflow:clip (clip does not enable
3764-
resize)
3763+
visible-overflow-no-resize warn: resize: both + overflow: clip — clip does not enable resize
37653764
</div>
3766-
<div data-target style="resize: both; overflow: clip; width: 200px; height: 100px">
3767-
overflow: clip does not create a scroll container, so resize has no effect
3765+
<div
3766+
data-target
3767+
style="resize: both; overflow: clip; width: 200px; height: 80px; background: #e8e8e8"
3768+
>
3769+
resize: both + overflow: clip — no handle
37683770
</div>
37693771
</div>
37703772

37713773
<h3>Should NOT warn</h3>
37723774
<div class="case expect-ok" data-rule="visible-overflow-no-resize">
37733775
<div class="label label-ok">
3774-
visible-overflow-no-resize ok: resize:both with overflow:auto (correct usage)
3776+
visible-overflow-no-resize ok: resize: both + overflow: auto — resize handle visible in
3777+
bottom-right corner
37753778
</div>
3776-
<div data-target style="resize: both; overflow: auto; width: 200px; height: 100px">
3777-
This div is properly resizable with overflow: auto
3779+
<div
3780+
data-target
3781+
style="resize: both; overflow: auto; width: 200px; height: 80px; background: #e8e8e8"
3782+
>
3783+
resizable — drag handle at bottom-right
37783784
</div>
37793785
</div>
37803786
<div class="case expect-ok" data-rule="visible-overflow-no-resize">
37813787
<div class="label label-ok">
3782-
visible-overflow-no-resize ok: resize:both with overflow:hidden
3783-
</div>
3784-
<div data-target style="resize: both; overflow: hidden; width: 200px; height: 100px">
3785-
This div is properly resizable with overflow: hidden
3788+
visible-overflow-no-resize ok: resize: both + overflow: hidden — resize handle visible
37863789
</div>
3787-
</div>
3788-
<div class="case expect-ok" data-rule="visible-overflow-no-resize">
3789-
<div class="label label-ok">
3790-
visible-overflow-no-resize ok: textarea (browser special-case)
3790+
<div
3791+
data-target
3792+
style="resize: both; overflow: hidden; width: 200px; height: 80px; background: #e8e8e8"
3793+
>
3794+
resizable — drag handle at bottom-right
37913795
</div>
3792-
<textarea data-target style="resize: both">Textarea resize works without overflow</textarea>
37933796
</div>
37943797
<div class="case expect-ok" data-rule="visible-overflow-no-resize">
37953798
<div class="label label-ok">
3796-
visible-overflow-no-resize ok: resize:none (default, no warning)
3797-
</div>
3798-
<div data-target style="resize: none; width: 200px; height: 100px">
3799-
resize: none is the default, should not warn
3799+
visible-overflow-no-resize ok: textarea — browser special-case, resize handle visible even
3800+
without overflow
38003801
</div>
3802+
<textarea data-target style="resize: both">Textarea — always resizable</textarea>
38013803
</div>
38023804

38033805
<!-- ===== visible-overflow-no-text-overflow: text-overflow on visible overflow ===== -->

0 commit comments

Comments
 (0)