1.1.7: window_ranges sort issue

[endrebak]

@marco-mariotti Do these changes look correct to you?

[endrebak]

Would hopefully fix

#98
#105

[marco-mariotti]

I can review tomorrow.
Just a point: it should follow the general guideline for methods: by default, return intervals in input order if possible, unless restore_order=False
as per #104

[marco-mariotti]

The restore order thing: yes, all methods where relevant (can't think exhaustively now. They may be all of them in which we do internal sorting) Marco Mariotti

…

On Sun, Dec 14, 2025, 11:16 endrebak ***@***.***> wrote: *endrebak* left a comment (pyranges/pyranges1#116) <#116 (comment)> Ah, so that is something all methods should be updated with? — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTXRIAVEHEKHNXHQVECAPD4BU2JDAVCNFSM6AAAAACO7O2ST2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNJQGY3DENRTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[marco-mariotti]

@endrebak I reviewed and it looks good. I also added the add_window_id argument as I had mentioned in the issue and updated docstring.

The only thing: this function does not preserve input order. Doing so is not straightforward (see for example how we do in other functions) because of duplicated indices in output. I just added a warning. I think this is fine