Skip to content

Commit 1eca97a

Browse files
committed
Address reviewer comments.
1 parent 4cc1084 commit 1eca97a

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

src/greenlet/PyModule.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ mod_enable_optional_cleanup(PyObject* UNUSED(module), PyObject* flag)
168168
return nullptr;
169169
}
170170

171-
std::clock_t clocks = ThreadState::clocks_used_doing_gc();
172171
if (is_true) {
172+
std::clock_t clocks = ThreadState::clocks_used_doing_gc();
173173
// If we already have a value, we don't want to lose it.
174174
if (clocks == std::clock_t(-1)) {
175175
ThreadState::set_clocks_used_doing_gc(0);

tox.ini

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
[tox]
22
envlist =
3-
py{37,38,39,310,311,312,313,314},py{310,311,312,313,314}-ns,docs
3+
py{37,38,39,310,311,312,313,314},py{310,311,312,313,314}-ns,docs,py314t,tsan-314#,tsan-314t
44

55
[testenv]
66
commands =
77
python -c 'import greenlet._greenlet as G; assert G.GREENLET_USE_STANDARD_THREADING'
8-
python -m unittest discover -v greenlet.tests
8+
python -m unittest discover greenlet.tests
99
sphinx-build -b doctest -d docs/_build/doctrees-{envname} docs docs/_build/doctest-{envname}
1010
sitepackages = False
1111
extras =
@@ -21,3 +21,13 @@ commands =
2121
sphinx-build -b html -d docs/_build/doctrees docs docs/_build/html
2222
sphinx-build -b doctest -d docs/_build/doctrees docs docs/_build/doctest
2323
extras = docs
24+
25+
[testenv:tsan-314t]
26+
basepython = /usr/local/python-builds/tsan/bin/python3.14t
27+
passenv =
28+
TSAN_OPTIONS
29+
30+
[testenv:tsan-314]
31+
basepython = /usr/local/python-builds/default-tsan/bin/python3.14
32+
passenv =
33+
TSAN_OPTIONS

0 commit comments

Comments
 (0)