Skip to content

Commit 9191620

Browse files
authored
fix(ci): build the Windows download artifact name in the right order (#4578)
Co-authored-by: shoumikhin <shoumikhin@users.noreply.github.com>
1 parent 8c1d660 commit 9191620

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/windows-test.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,15 @@ jobs:
108108
setup-miniconda: false
109109
python-version: ${{ env.PYTHON_VERSION }}
110110
cuda-version: ${{ env.CU_VERSION }}
111-
arch: ${{ env.ARCH }}
111+
# Same value build_windows.yml passes, so the name built here comes out
112+
# identical to the one the build uploaded. ARCH is not set anywhere in
113+
# this workflow, so the architecture has to come from the input.
114+
arch: ${{ inputs.architecture }}
112115
# The default matrix entries have matrix.tensorrt == '', so their
113116
# download branch uses ARTIFACT_NAME rather than DOWNLOAD_ARTIFACT_NAME.
114-
# Keep it aligned with the RTX build artifact.
117+
# Keep it aligned with the RTX build artifact. The build adds these two
118+
# suffixes after the architecture, so they have to stay after the step
119+
# above, which is what puts the architecture in the name.
115120
- name: Mark Python-only artifact
116121
if: ${{ inputs.python-only }}
117122
run: echo "ARTIFACT_NAME=${ARTIFACT_NAME}_python_only" >> "${GITHUB_ENV}"
@@ -135,7 +140,7 @@ jobs:
135140
if: ${{ matrix.tensorrt == '' }}
136141
uses: actions/download-artifact@v7
137142
with:
138-
name: ${{ env.ARTIFACT_NAME }}${{ inputs.architecture }}
143+
name: ${{ env.ARTIFACT_NAME }}
139144
path: ${{ runner.temp }}/artifacts/
140145
- name: Download artifacts
141146
if: ${{ matrix.tensorrt != '' }}

0 commit comments

Comments
 (0)