firmware: fix AMD SME memory-encryption verdict

Author: q1sh101

include/silicon_parsers.h

@@ -21,7 +21,6 @@ typedef enum {
 
 typedef struct {
     bool amd_sme;
-    bool amd_sme_active;
     bool intel_tme;
 } bythos_mem_enc_flags_t;
 

src/check_memory_encryption.c

@@ -35,10 +35,9 @@ size_t bythos_check_memory_encryption(check_result_t *results, size_t max_result
         if (!flags.amd_sme) {
             EMIT_SKIP("memory encryption", SKIP_FEATURE_ABSENT,
                 "CPU encryption flags not detected");
-        } else if (flags.amd_sme_active) {
-            EMIT("memory encryption", CHECK_OK, "AMD SME active");
         } else {
-            EMIT("memory encryption", CHECK_WARN, "AMD SME supported but inactive");
+            EMIT("memory encryption", CHECK_OK,
+                "AMD SME capability present; activation not verified");
         }
     } else {
         if (!flags.intel_tme) {

src/silicon_parsers.c

@@ -167,9 +167,8 @@ void bythos_parse_memory_encryption_flags(const char *cpuinfo,
         return;
     }
 
-    flags->amd_sme        = token_present(flags_line, "sme");
-    flags->amd_sme_active = token_present(flags_line, "sme_active");
-    flags->intel_tme      = token_present(flags_line, "tme");
+    flags->amd_sme   = token_present(flags_line, "sme");
+    flags->intel_tme = token_present(flags_line, "tme");
 }
 
 bool bythos_extract_microcode_revision(const char *text, char *buffer, size_t size) {

tests/silicon_parsers.c

@@ -76,18 +76,11 @@ int main(void) {
         bythos_mem_enc_flags_t flags = {0};
 
         bythos_parse_memory_encryption_flags(
-            "vendor_id\t: AuthenticAMD\nflags\t\t: fpu vme de sme sme_active sev\n",
+            "vendor_id\t: AuthenticAMD\nflags\t\t: fpu vme de sme sev\n",
             &flags);
         assert_true("mem_enc_amd_sme", flags.amd_sme);
-        assert_true("mem_enc_amd_sme_active", flags.amd_sme_active);
         assert_false("mem_enc_amd_no_intel_tme", flags.intel_tme);
 
-        bythos_parse_memory_encryption_flags(
-            "vendor_id\t: AuthenticAMD\nflags\t\t: fpu vme de sme sev\n",
-            &flags);
-        assert_true("mem_enc_amd_sme_only", flags.amd_sme);
-        assert_false("mem_enc_amd_sme_active_absent", flags.amd_sme_active);
-
         bythos_parse_memory_encryption_flags(
             "vendor_id\t: GenuineIntel\nflags\t\t: fpu vme de tme x2apic\n",
             &flags);
@@ -101,10 +94,9 @@ int main(void) {
         assert_false("mem_enc_no_flags_tme", flags.intel_tme);
 
         bythos_parse_memory_encryption_flags(
-            "vendor_id\t: AuthenticAMD\nflags\t\t: fpu vme sme_active sev\n",
+            "vendor_id\t: AuthenticAMD\nflags\t\t: fpu vme smep smap sev\n",
             &flags);
         assert_false("mem_enc_word_boundary_sme", flags.amd_sme);
-        assert_true("mem_enc_word_boundary_sme_active", flags.amd_sme_active);
 
         bythos_parse_memory_encryption_flags(
             "vendor_id\t: AuthenticAMD\nmodel name\t: AMD Ryzen 9 5900HX\n",