issues fixes

Author: iceseer

src/modules/CMakeLists.txt

@@ -70,7 +70,7 @@ function(add_jam_module NAME)
 
   # Set C++ standard
   target_compile_features(${MODULE} PRIVATE
-      cxx_std_20
+      cxx_std_23
   )
 
   add_dependencies(all_modules ${MODULE})

src/se/impl/async_dispatcher_impl.hpp

@@ -13,7 +13,7 @@
 namespace jam::se {
 
   template <uint32_t kCount, uint32_t kPoolSize>
-  class AsyncDispatcher final : public IDispatcher {
+  class AsyncDispatcher final : public Dispatcher {
    public:
     // Disable copying
     AsyncDispatcher(const AsyncDispatcher &) = delete;
@@ -27,7 +27,7 @@ namespace jam::se {
     static constexpr uint32_t kPoolThreadsCount = kPoolSize;
 
    private:
-    using Parent = IDispatcher;
+    using Parent = Dispatcher;
 
     struct SchedulerContext {
       /// Scheduler to execute tasks

src/se/impl/dispatcher.hpp

@@ -13,14 +13,17 @@
 
 namespace jam::se {
 
-  struct IDispatcher {
+  /**
+   * Interface for task dispatchers that handle execution across different threads
+   */
+  struct Dispatcher {
     using Tid = uint32_t;
     using Task = IScheduler::Task;
     using Predicate = IScheduler::Predicate;
 
     static constexpr Tid kExecuteInPool = std::numeric_limits<Tid>::max();
 
-    virtual ~IDispatcher() = default;
+    virtual ~Dispatcher() = default;
 
     virtual std::optional<Tid> bind(std::shared_ptr<IScheduler> scheduler) = 0;
     virtual bool unbind(Tid tid) = 0;

src/se/impl/scheduler_impl.hpp

@@ -51,7 +51,7 @@ namespace jam::se {
     std::thread::id id_;
 
    private:
-    inline void checkLocked() {
+    void checkLocked() {
       /// Need to check that we are locked in debug.
       assert(!tasks_cs_.try_lock());
     }
@@ -104,6 +104,7 @@ namespace jam::se {
 
         return std::chrono::microseconds(0ull);
       }
+      // Default timeout when no tasks are pending - prevents busy waiting
       return std::chrono::minutes(10ull);
     }
 
@@ -147,6 +148,7 @@ namespace jam::se {
               }
             }
           } catch (...) {
+            // Ignore exceptions during task execution to prevent scheduler crash
           }
         } else {
           event_.wait(untilFirst());

src/se/impl/subscription_engine.hpp

@@ -17,6 +17,9 @@
 
 namespace jam::se {
 
+  /**
+   * Interface for objects that can be disposed/cleaned up
+   */
   struct IDisposable {
     virtual void dispose() = 0;
   };

src/se/impl/subscription_manager.hpp

@@ -17,6 +17,13 @@
 #include "subscriber.hpp"
 #include "subscription_engine.hpp"
 
+// Cross-platform function name macro for subscription hashing
+#ifdef _WIN32
+#define FUNCTION_NAME __FUNCSIG__
+#else
+#define FUNCTION_NAME __PRETTY_FUNCTION__
+#endif
+
 namespace jam::se {
 
   /**
@@ -38,7 +45,7 @@ namespace jam::se {
     SubscriptionManager(SubscriptionManager &&) = delete;
     SubscriptionManager &operator=(SubscriptionManager &&) = delete;
 
-    using Dispatcher = jam::se::IDispatcher;
+    using Dispatcher = jam::se::Dispatcher;
 
    private:
     using EngineHash = uint64_t;
@@ -56,11 +63,7 @@ namespace jam::se {
    private:
     template <typename... Args>
     static constexpr EngineHash getSubscriptionHash() {
-#ifdef _WIN32
-      constexpr EngineHash value = CT_MURMUR2(__FUNCSIG__);
-#else   //_WIN32
-      constexpr EngineHash value = CT_MURMUR2(__PRETTY_FUNCTION__);
-#endif  //_WIN32
+      constexpr EngineHash value = CT_MURMUR2(FUNCTION_NAME);
       return value;
     }
 

src/se/impl/sync_dispatcher_impl.hpp

@@ -12,9 +12,9 @@
 namespace jam::se {
 
   template <uint32_t kCount, uint32_t kPoolSize>
-  class SyncDispatcher final : public IDispatcher {
+  class SyncDispatcher final : public Dispatcher {
    private:
-    using Parent = IDispatcher;
+    using Parent = Dispatcher;
 
    public:
     // Disable copying

src/se/subscription_fwd.hpp

@@ -24,7 +24,7 @@ namespace jam {
   static constexpr uint32_t kThreadPoolSize = 3u;
 
   namespace se {
-    struct IDispatcher;
+    struct Dispatcher;
 
     template <uint32_t kHandlersCount, uint32_t kPoolSize>
     class SubscriptionManager;
@@ -36,7 +36,7 @@ namespace jam {
     class SubscriberImpl;
   }  // namespace se
 
-  using Dispatcher = se::IDispatcher;
+  using Dispatcher = se::Dispatcher;
   using Subscription =
       se::SubscriptionManager<SubscriptionEngineHandlers::kTotalCount,
                               kThreadPoolSize>;