safe down cast

Author: elpaso

src/server/services/wfs3/qgswfs3handlers.cpp

@@ -675,14 +675,14 @@ void QgsWfs3AbstractItemsHandler::gatherLayerFieldsInfo( json &data, const QgsVe
           const QgsExpression expression( constraints.constraintExpression() );
           if ( expression.isValid() && expression.rootNode()->dump().startsWith( "regexp_match("_L1 ) )
           {
-            if ( const QgsExpressionNodeFunction *functionNode = qgis::down_cast<const QgsExpressionNodeFunction *>( expression.rootNode() ) )
+            if ( const QgsExpressionNodeFunction *functionNode = dynamic_cast<const QgsExpressionNodeFunction *>( expression.rootNode() ) )
             {
               QgsExpressionNode::NodeList *functionArgs = functionNode->args();
               if ( functionArgs->count() == 2 )
               {
-                if ( const QgsExpressionNodeColumnRef *columnNode = qgis::down_cast<const QgsExpressionNodeColumnRef *>( functionArgs->at( 0 ) ); columnNode->name() == field.name() )
+                if ( const QgsExpressionNodeColumnRef *columnNode = dynamic_cast<const QgsExpressionNodeColumnRef *>( functionArgs->at( 0 ) ); columnNode->name() == field.name() )
                 {
-                  if ( const QgsExpressionNodeLiteral *patternNode = qgis::down_cast<const QgsExpressionNodeLiteral *>( functionArgs->at( 1 ) ) )
+                  if ( const QgsExpressionNodeLiteral *patternNode = dynamic_cast<const QgsExpressionNodeLiteral *>( functionArgs->at( 1 ) ) )
                   {
                     fInfo.pattern = patternNode->value().toString().toStdString();
                   }

tests/src/python/test_qgsserver_ogcapi_schema.py

@@ -253,6 +253,36 @@ def _test_widget_conf(
             expression="regexp_match(\"field1\", '^[A-Z]{3}$')",
         )
 
+        # Field with regexp expression constraint but on another field - should not be picked up as a pattern constraint
+        field = QgsField("field1", QtCore.QMetaType.Type.QString)
+        _test_widget_conf(
+            field,
+            "TextEdit",
+            {},
+            {
+                "type": "string",
+                "readOnly": True,
+                "x-ogc-propertySeq": 2,
+            },
+            read_only=True,
+            expression="regexp_match(\"field2\", '^[A-Z]{3}$')",
+        )
+
+        # Field with regexp expression constraint but taken from another field - should not be picked up as a pattern constraint
+        field = QgsField("field1", QtCore.QMetaType.Type.QString)
+        _test_widget_conf(
+            field,
+            "TextEdit",
+            {},
+            {
+                "type": "string",
+                "readOnly": True,
+                "x-ogc-propertySeq": 2,
+            },
+            read_only=True,
+            expression='regexp_match("field1", "refield")',
+        )
+
         # ValueMap
         _test_widget_conf(
             QgsField("field1", QtCore.QMetaType.Type.QString),