Skip to content

Commit 18973eb

Browse files
authored
Merge pull request #38 from qmfrederik/features/remove-gnustep-cmake
Remove gnustep-cmake
2 parents b28d9b5 + 8621bc8 commit 18973eb

8 files changed

Lines changed: 14 additions & 180 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,13 @@ jobs:
5858
run: conan create gnustep-gui --profile:a=${{ github.workspace }}/profiles/windows-clang
5959
- name: Install gnustep-headless
6060
run: conan create gnustep-headless --profile:a=${{ github.workspace }}/profiles/windows-clang
61-
- name: Install gnustep-cmake
62-
run: conan create gnustep-cmake --profile:a=${{ github.workspace }}/profiles/windows-clang
6361
- name: Build tutorial
6462
run: |
6563
conan install conanfile.txt --profile:a=../profiles/windows-clang --output-folder=build/ --conf="tools.env.virtualenv:powershell=pwsh.exe"
66-
cd build/
67-
cmake .. -DCMAKE_TOOLCHAIN_FILE="conan_toolchain.cmake" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -GNinja
68-
cmake --build .
69-
./conanrun.ps1
70-
./Tutorial.exe
64+
cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE="conan_toolchain.cmake" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -GNinja
65+
cmake --build build
66+
./build/conanrun.ps1
67+
./build/Tutorial.exe
7168
working-directory: tutorial/
7269
- name: Upload Conan packages to Cloudsmith
7370
run: |
@@ -180,16 +177,13 @@ jobs:
180177
if: matrix.family == 'rhel'
181178
- name: Install gnustep-headless
182179
run: .python3/bin/conan create gnustep-headless --profile:a=profiles/linux-clang
183-
- name: Install gnustep-cmake
184-
run: .python3/bin/conan create gnustep-cmake --profile:a=profiles/linux-clang
185180
- name: Build tutorial
186181
run: |
187182
../.python3/bin/conan install conanfile.txt --profile:a=../profiles/linux-clang --output-folder=build/
188-
cd build/
189-
CC=clang CXX=clang++ LDFLAGS="-fuse-ld=lld" cmake .. -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release
190-
cmake --build .
191-
. ./conanrun.sh
192-
./Tutorial
183+
CC=clang CXX=clang++ LDFLAGS="-fuse-ld=lld" cmake -S. -B build/ -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release
184+
cmake --build build
185+
. build/conanrun.sh
186+
./build/Tutorial
193187
working-directory: tutorial/
194188
- uses: actions/upload-artifact@v4
195189
if: always()

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ conan create gnustep-make --profile:a=profiles/windows-clang
4040
conan create gnustep-base --profile:a=profiles/windows-clang
4141
conan create gnustep-gui --profile:a=profiles/windows-clang
4242
conan create gnustep-headless --profile:a=profiles/windows-clang
43-
conan create gnustep-cmake --profile:a=profiles/windows-clang
4443
```
4544

4645
This will configure GNUstep Base and all of its dependencies.
@@ -64,7 +63,6 @@ conan create gnustep-make --profile:a=profiles/linux-clang
6463
conan create gnustep-base --profile:a=profiles/linux-clang
6564
conan create gnustep-gui --profile:a=profiles/linux-clang
6665
conan create gnustep-headless --profile:a=profiles/linux-clang
67-
conan create gnustep-cmake --profile:a=profiles/linux-clang
6866
```
6967

7068
## Tips & Tricks

gnustep-base/test_package/test_package.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ @implementation Test
1515

1616
int main(void)
1717
{
18+
// Basic tests of gnustep-base
19+
NSLog(@"Hello, World!");
20+
1821
// This ensures we have a healty Objective C development environment once gnustep-make has been configured.
1922
// In particular, we're testing the various Objective C compiler options (ABI, exception model,...) are configured
2023
// correctly, by invoking an Objective C method which throws.

gnustep-cmake/CMakeLists.txt

Lines changed: 0 additions & 7 deletions
This file was deleted.

gnustep-cmake/GNUstepConfig.cmake

Lines changed: 0 additions & 105 deletions
This file was deleted.

gnustep-cmake/conanfile.py

Lines changed: 0 additions & 46 deletions
This file was deleted.

tutorial/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.10)
33
project(Tutorial)
44

55
find_package(libobjc2)
6-
find_package(GNUstep)
6+
find_package(gnustep-base)
77

88
add_executable(Tutorial main.m)
9-
target_link_libraries(Tutorial GNUstep::Base)
9+
target_link_libraries(Tutorial gnustep-base::gnustep-base libobjc2::libobjc2)

tutorial/conanfile.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
[requires]
2-
gnustep-base/[^1.31.1]
32
libobjc2/[^2.2.1]
4-
5-
[tool_requires]
6-
gnustep-cmake/[^0.1.0]
3+
gnustep-base/[^1.31.1]
74

85
[generators]
96
CMakeDeps

0 commit comments

Comments
 (0)