refactor(sdk): remove dead license_key / validation subsystem

GENIEX_VALIDATION is never defined by any build file, so the entire
license-validation path was compiled out. No plugin implements
is_validation_needed, so the create()/create_impl() split existed only
to host the dead dispatch. Delete validation.h, IValidatable.h, the
license_id/license_key fields on the create-input structs, the
LICENSE_INVALID/EXPIRED error codes, and the Python-binding mirrors;
collapse create()/create_impl() back into a single create() per modality.

Signed-off-by: Mengsheng Wu <mengshengwu@outlook.com>

Author: mengshengwu

bindings/python/geniex/_ffi/_types.py

@@ -146,8 +146,6 @@ class geniex_LlmCreateInput(Structure):
         ('config', geniex_ModelConfig),
         ('plugin_id', c_char_p),
         ('device_id', c_char_p),
-        ('license_id', c_char_p),
-        ('license_key', c_char_p),
     ]
 
 
@@ -228,8 +226,6 @@ class geniex_VlmCreateInput(Structure):
         ('plugin_id', c_char_p),
         ('device_id', c_char_p),
         ('tokenizer_path', c_char_p),
-        ('license_id', c_char_p),
-        ('license_key', c_char_p),
     ]
 
 

bindings/python/geniex/auto.py

@@ -313,8 +313,6 @@ def _create_vlm_handle(
     plugin_id: str | None,
     device_id: str | None,
     config: geniex_ModelConfig,
-    license_id: str | None,
-    license_key: str | None,
     meta: dict | None = None,
 ) -> GenieXVLM:
     inp = geniex_VlmCreateInput(
@@ -330,10 +328,6 @@ def _create_vlm_handle(
         inp.plugin_id = plugin_id.encode()
     if device_id:
         inp.device_id = device_id.encode()
-    if license_id:
-        inp.license_id = license_id.encode()
-    if license_key:
-        inp.license_key = license_key.encode()
 
     handle = c_void_p()
     lib = load_library()
@@ -356,8 +350,6 @@ def from_pretrained(
         n_gpu_layers: int = -1,
         mmproj_path: str | None = None,
         tokenizer_path: str | None = None,
-        license_id: str | None = None,
-        license_key: str | None = None,
         hf_token: str | None = None,
         progress: ProgressCallback | bool | None = None,
         **kwargs,
@@ -407,8 +399,6 @@ def from_pretrained(
                 plugin_id,
                 device_id,
                 config,
-                license_id,
-                license_key,
                 meta=meta,
             )
 
@@ -423,10 +413,6 @@ def from_pretrained(
             inp.plugin_id = plugin_id.encode()
         if device_id:
             inp.device_id = device_id.encode()
-        if license_id:
-            inp.license_id = license_id.encode()
-        if license_key:
-            inp.license_key = license_key.encode()
 
         handle = c_void_p()
         lib = load_library()
@@ -449,8 +435,6 @@ def from_pretrained(
         n_gpu_layers: int = -1,
         mmproj_path: str | None = None,
         tokenizer_path: str | None = None,
-        license_id: str | None = None,
-        license_key: str | None = None,
         hf_token: str | None = None,
         progress: ProgressCallback | bool | None = None,
         **kwargs,
@@ -495,7 +479,5 @@ def from_pretrained(
             plugin_id,
             device_id,
             config,
-            license_id,
-            license_key,
             meta=meta,
         )

sdk/include/geniex.h

@@ -67,9 +67,6 @@ typedef enum {
     GENIEX_ERROR_COMMON_PLUGIN_LOAD    = -100301, /**< Plugin loading failed */
     GENIEX_ERROR_COMMON_PLUGIN_INVALID = -100302, /**< Invalid plugin */
 
-    GENIEX_ERROR_COMMON_LICENSE_INVALID = -100601, /**< Invalid license */
-    GENIEX_ERROR_COMMON_LICENSE_EXPIRED = -100602, /**< License expired */
-
     /* ===== LLM ERRORS (200xxx) ===== */
 
     GENIEX_ERROR_LLM_TOKENIZATION_FAILED         = -200001, /**< Tokenization failed */
@@ -438,9 +435,6 @@ typedef struct {
     geniex_ModelConfig config;         /** Model configuration */
     geniex_PluginId    plugin_id;      /** plugin to use for the model */
     const char*        device_id;      /** device to use for the model, NULL for default device */
-    const char* license_id;  /** licence id for loading NPU models, must be provided upon the first use of the license
-                                key. null terminated string */
-    const char* license_key; /** licence key for loading NPU models, null terminated string */
 } geniex_LlmCreateInput;
 
 /**
@@ -639,9 +633,6 @@ typedef struct {
     geniex_PluginId    plugin_id;      /** Plugin to use for the model */
     const char*        device_id;      /** device to use for the model */
     geniex_Path        tokenizer_path; /** Path to the tokenizer file */
-    const char* license_id;  /** licence id for loading NPU models, must be provided upon the first use of the license
-                                key. null terminated string */
-    const char* license_key; /** licence key for loading NPU models, null terminated string */
 } geniex_VlmCreateInput;
 
 /**

sdk/include/logging.h

@@ -342,16 +342,14 @@ struct fmt::formatter<geniex_VlmCreateInput> {
     auto           format(const geniex_VlmCreateInput& p, fmt::format_context& ctx) const {
         return fmt::format_to(ctx.out(),
             "VlmCreateInput(model_name: {}, model_path: {}, mmproj_path: {}, config: {}, plugin_id: {}, device_id: {}, "
-                      "tokenizer_path: {}, license_id: {}, license_key: {})",
+                      "tokenizer_path: {})",
             lp(p.model_name),
             lp(p.model_path),
             lp(p.mmproj_path),
             lp(p.config),
             lp(p.plugin_id),
             lp(p.device_id),
-            lp(p.tokenizer_path),
-            lp(p.license_id),
-            lp(p.license_key));
+            lp(p.tokenizer_path));
     }
 };
 

sdk/include/plugin/ILlm.h

@@ -3,7 +3,6 @@
 
 #pragma once
 
-#include "IValidatable.h"
 #include "geniex.h"
 
 namespace geniex {
@@ -13,27 +12,11 @@ class ILlm {
     virtual ~ILlm() = default;
 
     /**
-     * @brief Create the LLM model with optional validation
+     * @brief Create and initialize the LLM model
      * @param input The creation input parameters
      * @return ML error code (GENIEX_SUCCESS on success, negative on failure)
      */
-    virtual int32_t create(const geniex_LlmCreateInput* input) {
-        // Check if this instance implements IValidatable
-        auto* validatable = dynamic_cast<IValidatable<geniex_LlmCreateInput>*>(this);
-        if (validatable) {
-            // Check if validation is needed
-            if (validatable->is_validation_needed(input)) {
-                // Perform validation
-                int32_t validation_result = validatable->validate(input);
-                if (validation_result != GENIEX_SUCCESS) {
-                    return validation_result;
-                }
-            }
-        }
-
-        // Call the actual implementation
-        return create_impl(input);
-    }
+    virtual int32_t create(const geniex_LlmCreateInput* input) = 0;
 
     virtual int32_t reset() = 0;
 
@@ -52,14 +35,6 @@ class ILlm {
      * information keep building. Plugins able to report it MUST override.
      */
     virtual int32_t get_model_info(geniex_LlmModelInfo*) { return GENIEX_ERROR_COMMON_PARAM_NOT_SUPPORTED; }
-
-   protected:
-    /**
-     * @brief Pure virtual method for actual model creation implementation
-     * @param input The creation input parameters
-     * @return ML error code (GENIEX_SUCCESS on success, negative on failure)
-     */
-    virtual int32_t create_impl(const geniex_LlmCreateInput* input) = 0;
 };
 
 }  // namespace geniex

sdk/include/plugin/IValidatable.h

@@ -3,7 +3,6 @@
 
 #pragma once
 
-#include "IValidatable.h"
 #include "geniex.h"
 
 namespace geniex {
@@ -13,27 +12,11 @@ class IVlm {
     virtual ~IVlm() = default;
 
     /**
-     * @brief Create the VLM model with optional validation
+     * @brief Create and initialize the VLM model
      * @param input The creation input parameters
      * @return ML error code (GENIEX_SUCCESS on success, negative on failure)
      */
-    virtual int32_t create(const geniex_VlmCreateInput* input) {
-        // Check if this instance implements IValidatable
-        auto* validatable = dynamic_cast<IValidatable<geniex_VlmCreateInput>*>(this);
-        if (validatable) {
-            // Check if validation is needed
-            if (validatable->is_validation_needed(input)) {
-                // Perform validation
-                int32_t validation_result = validatable->validate(input);
-                if (validation_result != GENIEX_SUCCESS) {
-                    return validation_result;
-                }
-            }
-        }
-
-        // Call the actual implementation
-        return create_impl(input);
-    }
+    virtual int32_t create(const geniex_VlmCreateInput* input) = 0;
 
     virtual int32_t reset() = 0;
 
@@ -48,14 +31,6 @@ class IVlm {
         output->supports_audio  = false;
         return GENIEX_SUCCESS;
     }
-
-   protected:
-    /**
-     * @brief Pure virtual method for actual model creation implementation
-     * @param input The creation input parameters
-     * @return ML error code (GENIEX_SUCCESS on success, negative on failure)
-     */
-    virtual int32_t create_impl(const geniex_VlmCreateInput* input) = 0;
 };
 
 }  // namespace geniex