Address boolean alias review findings

Author: t-kalinowski

R/args.R

@@ -101,6 +101,17 @@ process_args <- function(args, app) {
       ) {
         stop_unrecognized_arg(a)
       }
+      if (is.null(spec) && startsWith(a, "--no-")) {
+        alt_name <- str_drop_prefix(name, "no_")
+        alt_spec <- app_opts[[alt_name]]
+        if (
+          !is.null(alt_spec) &&
+            identical(alt_spec$arg_type, "switch") &&
+            !has_negative_alias(alt_spec)
+        ) {
+          stop_unrecognized_arg(a)
+        }
+      }
     } else {
       # --name
       name <- str_drop_prefix(a, "--")

README.md

@@ -139,7 +139,7 @@ To omit the generated `--no-*` alias for a boolean switch, add
 ``` r
 #| description: Print version and exit.
 #| negative_alias: false
-version <- TRUE
+version <- FALSE
 ```
 
 Rapp parses option values as YAML 1.2, where bare `yes` and `no` are

tests/testthat/test-regressions.R

@@ -269,6 +269,11 @@ test_that("disabled boolean aliases are rejected before positional matching", {
     "Arguments not recognized: --no-flag",
     fixed = TRUE
   )
+  expect_error(
+    Rapp::run(false_default_app, "--no-flag=false"),
+    "Arguments not recognized: --no-flag=false",
+    fixed = TRUE
+  )
 })
 
 test_that("YAML 1.2 strings are preserved in parsed option values", {