chore: remove providers deployment support (#1004)

* chore: remove providers support

* chore: remove unused code

* fix: remove unnecesary flag

* test: fix register_fails_wrong_chain

Author: AlexD10S

crates/pop-chains/src/lib.rs

@@ -10,8 +10,6 @@ pub mod bench;
 mod build;
 /// Provides functionality to construct, encode, sign, and submit chain extrinsics.
 mod call;
-/// Deployment providers' metadata and utility functions.
-mod deployer_providers;
 /// Error types and handling for the crate.
 mod errors;
 /// Code generation utilities.
@@ -26,6 +24,8 @@ pub mod omni_node;
 pub mod registry;
 /// Relay chain interaction and management.
 mod relay;
+/// Supported chains and their RPC endpoints.
+mod supported_chains;
 /// Template definitions and processing.
 mod templates;
 /// Common traits used throughout the crate.
@@ -62,12 +62,12 @@ pub use call::{
 	},
 	parse_and_format_events, set_up_client, sign_and_submit_extrinsic, submit_signed_extrinsic,
 };
-pub use deployer_providers::{DeploymentProvider, SupportedChains};
 pub use errors::Error;
 pub use indexmap::IndexSet;
 pub use new_chain::instantiate_template_dir;
 pub use new_pallet::{TemplatePalletConfig, create_pallet_template, new_pallet_options::*};
 pub use relay::{RelayChain, Reserved, clear_dmpq};
+pub use supported_chains::SupportedChains;
 pub use try_runtime::{
 	TryRuntimeCliCommand, binary::*, parse, parse_try_state_string, run_try_runtime,
 	shared_parameters::*, state, try_state_details, try_state_label, upgrade_checks_details,

…tes/pop-chains/src/deployer_providers.rs crates/pop-chains/src/supported_chains.rscrates/pop-chains/src/deployer_providers.rs renamed to crates/pop-chains/src/supported_chains.rs crates/pop-chains/src/deployer_providers.rs renamed to crates/pop-chains/src/supported_chains.rs

@@ -1,80 +1,7 @@
 // SPDX-License-Identifier: GPL-3.0
 
 use std::time::{SystemTime, UNIX_EPOCH};
-use strum::{EnumMessage as _, EnumProperty as _};
-use strum_macros::{AsRefStr, Display, EnumMessage, EnumProperty, EnumString, VariantArray};
-
-/// Supported deployment providers.
-#[derive(
-	AsRefStr,
-	Clone,
-	Debug,
-	Display,
-	EnumMessage,
-	EnumString,
-	EnumProperty,
-	Eq,
-	PartialEq,
-	VariantArray,
-)]
-pub enum DeploymentProvider {
-	/// Polkadot Deployment Portal (PDP). This provider enables seamless deployment of Polkadot
-	/// Native Chains through the Polkadot Cloud.
-	#[strum(
-		ascii_case_insensitive,
-		serialize = "pdp",
-		message = "Polkadot Deployment Portal",
-		detailed_message = "Effortlessly deploy Polkadot Native Chains on the Polkadot Cloud",
-		props(
-			BaseURL = "https://staging.deploypolkadot.xyz",
-			CollatorKeysURI = "/api/public/v1/parachains/{para_id}/collators/{chain_name}",
-			DeployURI = "/api/public/v1/parachains/{para_id}/resources",
-		)
-	)]
-	PDP,
-}
-
-impl DeploymentProvider {
-	/// Returns the name of the provider.
-	pub fn name(&self) -> &'static str {
-		self.get_message().unwrap_or_default()
-	}
-
-	/// Returns the detailed description of the provider.
-	pub fn description(&self) -> &'static str {
-		self.get_detailed_message().unwrap_or_default()
-	}
-
-	/// Returns the base URL of the provider.
-	pub fn base_url(&self) -> &'static str {
-		self.get_str("BaseURL").unwrap_or("")
-	}
-
-	/// Constructs the full URI for querying collator keys.
-	///
-	/// # Arguments
-	/// * `relay_chain_name` - The name of the relay chain where deployment will occur.
-	/// * `id` - The ID for which collator keys are being requested.
-	pub fn get_collator_keys_uri(&self, relay_chain_name: &str, id: u32) -> String {
-		self.get_str("CollatorKeysURI")
-			.map(|template| {
-				template
-					.replace("{para_id}", &id.to_string())
-					.replace("{chain_name}", relay_chain_name)
-			})
-			.unwrap_or_default()
-	}
-
-	/// Constructs the full URI for deploying a parachain.
-	///
-	/// # Arguments
-	/// * `id` - The ID that is being deployed.
-	pub fn get_deploy_uri(&self, id: u32) -> String {
-		self.get_str("DeployURI")
-			.map(|template| template.replace("{para_id}", &id.to_string()))
-			.unwrap_or_default()
-	}
-}
+use strum_macros::{Display, EnumString, VariantArray};
 
 /// Supported chains with its public RPC endpoints.
 #[derive(Debug, Clone, Copy, PartialEq, Eq, EnumString, Display, VariantArray, clap::ValueEnum)]
@@ -204,40 +131,6 @@ mod tests {
 	use super::*;
 	use strum::VariantArray;
 
-	#[test]
-	fn get_name_works() {
-		assert_eq!(DeploymentProvider::PDP.name(), "Polkadot Deployment Portal");
-	}
-
-	#[test]
-	fn get_description_works() {
-		assert_eq!(
-			DeploymentProvider::PDP.description(),
-			"Effortlessly deploy Polkadot Native Chains on the Polkadot Cloud"
-		);
-	}
-
-	#[test]
-	fn base_url_works() {
-		let provider = DeploymentProvider::PDP;
-		assert_eq!(provider.base_url(), "https://staging.deploypolkadot.xyz");
-	}
-
-	#[test]
-	fn get_collator_keys_uri_works() {
-		let provider = DeploymentProvider::PDP;
-		assert_eq!(
-			provider.get_collator_keys_uri("paseo", 2000),
-			"/api/public/v1/parachains/2000/collators/paseo"
-		);
-	}
-
-	#[test]
-	fn get_deploy_uri_works() {
-		let provider = DeploymentProvider::PDP;
-		assert_eq!(provider.get_deploy_uri(2000), "/api/public/v1/parachains/2000/resources");
-	}
-
 	#[test]
 	fn ensures_get_rpc_url_returns_valid_url() {
 		for chain in SupportedChains::VARIANTS {

crates/pop-chains/src/templates.rs

@@ -102,7 +102,6 @@ pub enum ChainTemplate {
 			Repository = "https://github.com/r0gue-io/base-parachain",
 			Network = "./network.toml",
 			License = "Unlicense",
-			DeploymentName = "POP_STANDARD"
 		)
 	)]
 	Standard,
@@ -117,7 +116,6 @@ pub enum ChainTemplate {
 			Repository = "https://github.com/r0gue-io/assets-parachain",
 			Network = "./network.toml",
 			License = "Unlicense",
-			DeploymentName = "POP_ASSETS"
 		)
 	)]
 	Assets,
@@ -131,7 +129,6 @@ pub enum ChainTemplate {
 			Repository = "https://github.com/r0gue-io/contracts-parachain",
 			Network = "./network.toml",
 			License = "Unlicense",
-			DeploymentName = "POP_CONTRACTS"
 		)
 	)]
 	Contracts,
@@ -147,7 +144,6 @@ pub enum ChainTemplate {
 			SupportedVersions = "v1.0.0,v2.0.1,v2.0.3,v3.0.0,v4.0.0",
 			IsAudited = "true",
 			License = "GPL-3.0",
-			DeploymentName = "OZ_GENERIC"
 		)
 	)]
 	OpenZeppelinGeneric,
@@ -163,7 +159,6 @@ pub enum ChainTemplate {
 			SupportedVersions = "v2.0.3,v3.0.0,v4.0.0",
 			IsAudited = "true",
 			License = "GPL-3.0",
-			DeploymentName = "OZ_EVM"
 		)
 	)]
 	OpenZeppelinEVM,
@@ -177,7 +172,6 @@ pub enum ChainTemplate {
 			Repository = "https://github.com/paritytech/polkadot-sdk-parachain-template",
 			Network = "./zombienet.toml",
 			License = "Unlicense",
-			DeploymentName = "PARITY_GENERIC"
 		)
 	)]
 	ParityGeneric,
@@ -245,28 +239,6 @@ impl ChainTemplate {
 		self.get_str("License")
 	}
 
-	/// Returns the deployment name for the parachain if defined.
-	pub fn deployment_name(&self) -> Option<&str> {
-		self.get_str("DeploymentName")
-	}
-
-	/// Retrieves the deployment name from the `based_on` value.
-	pub fn deployment_name_from_based_on(based_on: &str) -> Option<String> {
-		// OpenZeppelin special cases first (https://github.com/OpenZeppelin/polkadot-runtime-templates/pull/406)
-		let mapped_based_on = match based_on {
-			"OpenZeppelin EVM Template" => Some(ChainTemplate::OpenZeppelinEVM),
-			"OpenZeppelin Generic Template" => Some(ChainTemplate::OpenZeppelinGeneric),
-			_ => None,
-		};
-		if let Some(variant) = mapped_based_on {
-			return variant.deployment_name().map(String::from);
-		}
-		ChainTemplate::VARIANTS
-			.iter()
-			.find(|variant| variant.as_ref() == based_on)
-			.and_then(|variant| variant.deployment_name().map(String::from))
-	}
-
 	/// Gets the template name, removing the provider if present.
 	pub fn template_name_without_provider(&self) -> &str {
 		let name = self.as_ref();
@@ -375,20 +347,6 @@ mod tests {
 		.into()
 	}
 
-	fn template_deployment_name() -> HashMap<ChainTemplate, Option<&'static str>> {
-		[
-			(Standard, Some("POP_STANDARD")),
-			(Assets, Some("POP_ASSETS")),
-			(Contracts, Some("POP_CONTRACTS")),
-			(OpenZeppelinGeneric, Some("OZ_GENERIC")),
-			(OpenZeppelinEVM, Some("OZ_EVM")),
-			(ParityGeneric, Some("PARITY_GENERIC")),
-			(TestTemplate01, None),
-			(TestTemplate02, None),
-		]
-		.into()
-	}
-
 	#[test]
 	fn test_is_template_correct() {
 		for template in ChainTemplate::VARIANTS {
@@ -445,33 +403,6 @@ mod tests {
 		}
 	}
 
-	#[test]
-	fn deployment_name_works() {
-		let deployment_name = template_deployment_name();
-		for template in ChainTemplate::VARIANTS {
-			assert_eq!(template.deployment_name(), deployment_name[template]);
-		}
-	}
-
-	#[test]
-	fn deployment_name_from_based_on_works() {
-		for template in ChainTemplate::VARIANTS {
-			assert_eq!(
-				ChainTemplate::deployment_name_from_based_on(template.as_ref()),
-				template.deployment_name().map(String::from),
-			);
-		}
-		// test special cases
-		assert_eq!(
-			ChainTemplate::deployment_name_from_based_on("OpenZeppelin EVM Template"),
-			Some(OpenZeppelinEVM.deployment_name().unwrap().to_string())
-		);
-		assert_eq!(
-			ChainTemplate::deployment_name_from_based_on("OpenZeppelin Generic Template"),
-			Some(OpenZeppelinGeneric.deployment_name().unwrap().to_string())
-		);
-	}
-
 	#[test]
 	fn test_default_template_of_provider() {
 		let mut provider = Provider::Pop;