ci: extract lint into reusable workflow for early fail-fast (#983)

* ci: extract lint into standalone workflow with workflow_run gating

* ci: gate coverage workflow behind lint via workflow_run

* ci: revert to reusable workflow approach to avoid workflow_run security issues

* fix: use SubstrateTestNode instead of undeclared TestNode

Author: moliholy

.github/workflows/ci.yml

@@ -36,6 +36,9 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    uses: ./.github/workflows/lint.yml
+
   setup:
     runs-on: ubuntu-latest
     outputs:
@@ -65,22 +68,6 @@ jobs:
       docker_image: ${{ needs.setup.outputs.image }}
       rust_version: ${{ needs.setup.outputs.rust_version }}
 
-  lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Install Rust nightly
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: nightly
-          profile: minimal
-          components: rustfmt
-          override: true
-
-      - name: Check formatting
-        run: cargo +nightly fmt --all -- --check
-
   build:
     needs:
       - setup

.github/workflows/coverage.yml

@@ -34,7 +34,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    uses: ./.github/workflows/lint.yml
+
   build-tests:
+    needs: lint
     runs-on: ubuntu-latest
     env:
       CARGO_TARGET_DIR: target/llvm-cov-target

.github/workflows/integration-tests.yml

@@ -36,7 +36,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    uses: ./.github/workflows/lint.yml
+
   pop-fork-integration-tests:
+    needs: lint
     strategy:
       fail-fast: true
       matrix:
@@ -186,6 +190,7 @@ jobs:
           pkill eth-rpc || true
 
   contract-integration-tests:
+    needs: lint
     strategy:
       fail-fast: true
       matrix:
@@ -278,6 +283,7 @@ jobs:
             --status-level all
 
   chain-integration-tests:
+    needs: lint
     strategy:
       fail-fast: true
       matrix:
@@ -371,6 +377,7 @@ jobs:
             --status-level all
 
   pop-cli-integration-tests:
+    needs: lint
     strategy:
       fail-fast: true
       matrix:

.github/workflows/lint.yml

@@ -0,0 +1,24 @@
+name: lint
+
+permissions:
+  contents: read
+
+on:
+  workflow_call:
+
+jobs:
+  fmt:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust nightly
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: nightly
+          profile: minimal
+          components: rustfmt
+          override: true
+
+      - name: Check formatting
+        run: cargo +nightly fmt --all -- --check

crates/pop-cli/src/commands/call/chain.rs

@@ -1253,7 +1253,7 @@ mod tests {
 
 	#[tokio::test]
 	async fn execute_flag_skips_submit_extrinsic_confirmation_from_call_data_works() -> Result<()> {
-		let node = TestNode::spawn().await?;
+		let node = SubstrateTestNode::spawn().await?;
 		let node_url = node.ws_url();
 		let client = set_up_client(node_url).await?;
 		let call_config = CallChainCommand {