pop up network.toml in chain project takes too long

[Daanvdplas]

The runtime was already compiled, takes ages.

[moliholy]

The wasm blob was not generated, even with the already compiled runtime (or even if it was, we don't know whether the runtime's source code has been modified and the existing wasm blob is discardable). That's what takes time now and before it didn't, because the old node already contained the wasm blob within. But without node I am afraid there is no way around this if we want to ensure changes in the runtime's source code are always recompiled.

[moliholy]

Some benchmarks I made on my machine:

In a chain without node and only runtime:

pop up network.toml  335,11s user 2,04s system 704% **cpu 47,863 total**

In a chain with node:

pop up network.toml  159,16s user 1,29s system 452% cpu 35,436 total

As you can see, there is a ~12s difference, which is approximately the cost of building the chainspec when the runtime's wasm blob has to be regenerated. And indeed when running pop build spec isolated it takes around 11-12s.

[Daanvdplas]

How long does it take to generate the chainspec from the runtime? Should be less than a second no?

[moliholy]

No, takes like 10 seconds on a powerful MacBook Pro.

[Daanvdplas]

Hmm that really sucks. Not really a way around unfortunately either.

Users won't really need to deploy each time they make changes and should test in the pallet and runtime first.

[moliholy]

Users won't really need to deploy each time they make changes

If so they can simply NOT kill the network!

[Daanvdplas]

Don't follow

[moliholy]

So, if users do not need to relauch the network every time they make changes it's fine if they only launch it once and leave it there.

[Daanvdplas]

Yes of course

[moliholy]

@Daanvdplas anyhow... there's no way around this if using omni-node. Shall we close the issue?

[AlexD10S]

Reopening the issue. I think is a bit critical because in some machines it doesn't work.
For example pop up doesn't work for @tsenovilla , can you share some benchmarks on your machine? as Jose did in the message above?

[tsenovilla]

  🚫 Could not launch local network: Orchestrator error: Global network spawn timeout: 1000 secs
pop up network.toml  101,35s user 8,50s system 10% cpu 16:41,29 total

It just times out in my machine, not the command itself but the chain spawn. Tested with a freshly generated parachain with pop, using the version published on brew

[AlexD10S]

I just got the same error with the polkadot-stable2509-3 base-parachain upgrade: r0gue-io/base-parachain#74, not sure if was an internet issue but after a clean it worked again