Skip to content

Commit 7e0cffd

Browse files
Daanvdplasclaude
andcommitted
fix: simplify up_network to return raw output
Remove broken ws URL/PID parsing — pop CLI now writes network info to zombie.json. Return output directly and let agents use the path. Also update README with PRIVATE_KEY in all config examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 41c6017 commit 7e0cffd

8 files changed

Lines changed: 311 additions & 1043 deletions

File tree

AGENTS.md

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ cargo test --features pop-e2e # Integration tests
4646
### Commits
4747
- Conventional prefixes: `fix:`, `feat:`, `refactor:`
4848
- Imperative, ≤72 chars
49+
- **Pre-commit (Rust):** Run `cargo +nightly fmt --all` and `cargo clippy --all-features --all-targets` before committing Rust changes.
50+
51+
### Scope & Ownership
52+
- Before changing tests to fix upstream behavior, confirm the root cause and agree whether the fix belongs upstream or in this repo.
4953

5054
---
5155

@@ -112,37 +116,7 @@ async fn tool_name(&self, Parameters(params): Parameters<ToolParams>) -> Result<
112116

113117
- **Schema:** Must have `"type": "object"` and `"properties": {}` at top level
114118
- **Pop CLI:** Some commands return exit 0 on logical errors - check output text
115-
- **Lifetimes:** Store owned strings before building arg refs
116-
- **Ports:** Use non-default ports (9945, 8546) in tests to avoid conflicts
117-
118-
---
119-
120-
## Existing Tools
121-
122-
| Tool | Command | Key Params |
123-
|------|---------|------------|
124-
| `create_contract` | `pop new contract` | name, template |
125-
| `build_contract` | `pop build --path` | path, release |
126-
| `test_contract` | `pop test --path` | path, e2e |
127-
| `deploy_contract` | `pop up <path>` | path, constructor, args, suri, url |
128-
| `call_contract` | `pop call contract` | path, contract, message, args |
129-
| `up_ink_node` | `pop up ink-node` | ports |
130-
| `clean_nodes` | `pop clean node --pid` | pids |
131-
| `convert_address` | `pop convert address` | address |
132119

133-
---
134-
135-
## Future Tools
136-
137-
| Tool | Command | Purpose |
138-
|------|---------|---------|
139-
| `up_network` | `pop up paseo/kusama/...` | Connect to live networks |
140-
| `new_chain` | `pop new chain` | Create parachains |
141-
| `new_pallet` | `pop new pallet` | Create pallets |
142-
| `build_spec` | `pop build spec` | Build chain specs |
143-
| `call_chain` | `pop call chain` | Runtime calls |
144-
145-
---
146120

147121
## Adding New Tools
148122

Cargo.lock

Lines changed: 82 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ serde = { version = "1", features = ["derive"] }
1919
serde_json = "1"
2020
schemars = "1.0"
2121
anyhow = "1.0"
22+
toml = "0.8"
2223
tempfile = { version = "3", optional = true }
2324

2425
[dev-dependencies]

0 commit comments

Comments
 (0)