WIP: Export symbols also with enabled LTO

Author: radioactiveman

src/libaudcore/Makefile

@@ -35,6 +35,7 @@ SRCS = adder.cc \
        playlist-data.cc \
        playlist-files.cc \
        playlist-utils.cc \
+       plugin.cc \
        plugin-init.cc \
        plugin-load.cc \
        plugin-registry.cc \

src/libaudcore/meson.build

@@ -34,6 +34,7 @@ libaudcore_sources = [
   'playlist-data.cc',
   'playlist-files.cc',
   'playlist-utils.cc',
+  'plugin.cc',
   'plugin-init.cc',
   'plugin-load.cc',
   'plugin-registry.cc',

src/libaudcore/plugin.cc

@@ -0,0 +1,75 @@
+/*
+ * plugin.cc
+ * Copyright 2005-2013 Ariadne Conill, Yoshiki Yazawa, Eugene Zagidullin, and
+ *                     John Lindgren
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions, and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions, and the following disclaimer in the documentation
+ *    provided with the distribution.
+ *
+ * This software is provided "as is" and without any warranty, express or
+ * implied. In no event shall the authors be liable for any damages arising from
+ * the use of this software.
+ */
+
+#include "plugin.h"
+
+bool Plugin::init() { return true; }
+
+void Plugin::cleanup() {}
+
+int Plugin::take_message(const char * code, const void * data, int size)
+{
+    return -1;
+}
+
+VFSFileTest TransportPlugin::test_file(const char * filename, VFSFileTest test,
+                                       String & error)
+{
+    return VFSFileTest(0);
+}
+
+Index<String> TransportPlugin::read_folder(const char * filename, String & error)
+{
+    return Index<String>();
+}
+
+bool PlaylistPlugin::save(const char * path, VFSFile & file, const char * title,
+                          const Index<PlaylistAddItem> & items)
+{
+    return false;
+}
+
+void OutputPlugin::set_info(const char * filename, const Tuple & tuple) {}
+
+bool EffectPlugin::flush(bool force) { return true; }
+
+Index<float> & EffectPlugin::finish(Index<float> & data, bool end_of_playlist)
+{
+    return process(data);
+}
+
+int EffectPlugin::adjust_delay(int delay) { return delay; }
+
+bool InputPlugin::write_tuple(const char * filename, VFSFile & file,
+                              const Tuple & tuple)
+{
+    return false;
+}
+
+bool InputPlugin::file_info_box(const char * filename, VFSFile & file)
+{
+    return false;
+}
+
+void * DockablePlugin::get_gtk_widget() { return nullptr; }
+
+void * DockablePlugin::get_qt_widget() { return nullptr; }
+
+void IfacePlugin::startup_notify(const char * id) {}

src/libaudcore/plugin.h

@@ -129,13 +129,10 @@ class LIBAUDCORE_PUBLIC Plugin
     const PluginType type;
     const PluginInfo info;
 
-    virtual bool init() { return true; }
-    virtual void cleanup() {}
+    virtual bool init();
+    virtual void cleanup();
 
-    virtual int take_message(const char * code, const void * data, int size)
-    {
-        return -1;
-    }
+    virtual int take_message(const char * code, const void * data, int size);
 };
 
 class LIBAUDCORE_PUBLIC TransportPlugin : public Plugin
@@ -154,15 +151,9 @@ class LIBAUDCORE_PUBLIC TransportPlugin : public Plugin
                             String & error) = 0;
 
     virtual VFSFileTest test_file(const char * filename, VFSFileTest test,
-                                  String & error)
-    {
-        return VFSFileTest(0);
-    }
+                                  String & error);
 
-    virtual Index<String> read_folder(const char * filename, String & error)
-    {
-        return Index<String>();
-    }
+    virtual Index<String> read_folder(const char * filename, String & error);
 };
 
 class LIBAUDCORE_PUBLIC PlaylistPlugin : public Plugin
@@ -194,10 +185,7 @@ class LIBAUDCORE_PUBLIC PlaylistPlugin : public Plugin
      * title: title of playlist (in)
      * items: playlist entries (in) */
     virtual bool save(const char * path, VFSFile & file, const char * title,
-                      const Index<PlaylistAddItem> & items)
-    {
-        return false;
-    }
+                      const Index<PlaylistAddItem> & items);
 };
 
 class LIBAUDCORE_PUBLIC OutputPlugin : public Plugin
@@ -227,7 +215,7 @@ class LIBAUDCORE_PUBLIC OutputPlugin : public Plugin
 
     /* Sets information about the song being played.  This function will be
      * called before open_audio(). */
-    virtual void set_info(const char * filename, const Tuple & tuple) {}
+    virtual void set_info(const char * filename, const Tuple & tuple);
 
     /* Begins playback of a PCM stream.  <format> is one of the FMT_*
      * enumeration values defined in libaudcore/audio.h.  Returns true on
@@ -298,23 +286,20 @@ class LIBAUDCORE_PUBLIC EffectPlugin : public Plugin
      * perform crossfading).  The flush() function should return false in this
      * case to prevent flush() from being called in downstream effect plugins.
      */
-    virtual bool flush(bool force) { return true; }
+    virtual bool flush(bool force);
 
     /* Exactly like process() except that any buffers should be drained (i.e.
      * the data processed and returned).  finish() will be called a second time
      * at the end of the last song in the playlist. */
-    virtual Index<float> & finish(Index<float> & data, bool end_of_playlist)
-    {
-        return process(data);
-    }
+    virtual Index<float> & finish(Index<float> & data, bool end_of_playlist);
 
     /* Required only for plugins that change the time domain (e.g. a time
      * stretch) or use read-ahead buffering.  translate_delay() must do two
      * things: first, translate <delay> (which is in milliseconds) from the
      * output time domain back to the input time domain; second, increase
      * <delay> by the size of the read-ahead buffer.  It should return the
      * adjusted delay. */
-    virtual int adjust_delay(int delay) { return delay; }
+    virtual int adjust_delay(int delay);
 };
 
 enum class InputKey
@@ -427,18 +412,12 @@ class LIBAUDCORE_PUBLIC InputPlugin : public Plugin
 
     /* Optional.  Writes metadata to the file, returning false on error. */
     virtual bool write_tuple(const char * filename, VFSFile & file,
-                             const Tuple & tuple)
-    {
-        return false;
-    }
+                             const Tuple & tuple);
 
     /* Optional.  Displays a window showing info about the file.  In general,
      * this function should be avoided since Audacious already provides a file
      * info window. */
-    virtual bool file_info_box(const char * filename, VFSFile & file)
-    {
-        return false;
-    }
+    virtual bool file_info_box(const char * filename, VFSFile & file);
 
 protected:
     /* Prepares the output system for playback in the specified format.  Also
@@ -489,10 +468,10 @@ class LIBAUDCORE_PUBLIC DockablePlugin : public Plugin
     }
 
     /* GtkWidget * get_gtk_widget () */
-    virtual void * get_gtk_widget() { return nullptr; }
+    virtual void * get_gtk_widget();
 
     /* QWidget * get_qt_widget () */
-    virtual void * get_qt_widget() { return nullptr; }
+    virtual void * get_qt_widget();
 };
 
 class LIBAUDCORE_PUBLIC GeneralPlugin : public DockablePlugin
@@ -537,7 +516,7 @@ class LIBAUDCORE_PUBLIC IfacePlugin : public Plugin
                                  const char * icon) = 0;
     virtual void plugin_menu_remove(AudMenuID id, void func()) = 0;
 
-    virtual void startup_notify(const char * id) {}
+    virtual void startup_notify(const char * id);
 };
 
 #endif

src/libaudcore/vfs.cc

@@ -80,6 +80,8 @@ static TransportPlugin * lookup_transport(const char * filename, String & error,
     return nullptr;
 }
 
+String VFSImpl::get_metadata(const char * field) { return String(); }
+
 /**
  * Opens a stream from a VFS transport using one of the registered
  * #VFSConstructor handlers.

src/libaudcore/vfs.h

@@ -112,7 +112,7 @@ class LIBAUDCORE_PUBLIC VFSImpl
     virtual int ftruncate(int64_t length) = 0;
     virtual int fflush() = 0;
 
-    virtual String get_metadata(const char * field) { return String(); }
+    virtual String get_metadata(const char * field);
 };
 
 class VFSFile

src/libaudcore/visualization.cc

@@ -31,6 +31,10 @@ static Index<Visualizer *> visualizers;
 static int running = false;
 static int num_enabled = 0;
 
+void Visualizer::render_mono_pcm(const float * pcm) {}
+void Visualizer::render_multi_pcm(const float * pcm, int channels) {}
+void Visualizer::render_freq(const float * freq) {}
+
 EXPORT void aud_visualizer_add(Visualizer * vis)
 {
     visualizers.append(vis);

src/libaudcore/visualizer.h

@@ -39,13 +39,13 @@ class LIBAUDCORE_PUBLIC Visualizer
     virtual void clear() = 0;
 
     /* 512 frames of a single-channel PCM signal */
-    virtual void render_mono_pcm(const float * pcm) {}
+    virtual void render_mono_pcm(const float * pcm);
 
     /* 512 frames of an interleaved multi-channel PCM signal */
-    virtual void render_multi_pcm(const float * pcm, int channels) {}
+    virtual void render_multi_pcm(const float * pcm, int channels);
 
     /* intensity of frequencies 1/512, 2/512, ..., 256/512 of sample rate */
-    virtual void render_freq(const float * freq) {}
+    virtual void render_freq(const float * freq);
 
     /* common math for rendering a frequency graph (see util.cc) */
     static void compute_log_xscale(float * xscale, int bands);

src/libaudqt/colorbutton.cc

@@ -43,6 +43,8 @@ ColorButton::ColorButton(QWidget * parent) : QPushButton(parent)
     });
 }
 
+ColorButton::~ColorButton() = default;
+
 void ColorButton::setColor(const QColor & color)
 {
     if (color != m_color)
@@ -54,6 +56,8 @@ void ColorButton::setColor(const QColor & color)
     }
 }
 
+void ColorButton::onColorChanged() {}
+
 void ColorButton::paintEvent(QPaintEvent * event)
 {
     QPushButton::paintEvent(event);

src/libaudqt/colorbutton.h

@@ -32,14 +32,14 @@ class LIBAUDQT_PUBLIC ColorButton : public QPushButton
 {
 public:
     ColorButton(QWidget * parent = nullptr);
-    ~ColorButton(){};
+    ~ColorButton();
 
     void setColor(const QColor &);
 
     QColor color() const { return m_color; }
 
 protected:
-    virtual void onColorChanged(){};
+    virtual void onColorChanged();
 
 private:
     void paintEvent(QPaintEvent *) override;