Merge pull request #161 from rage-rb/sub-ms-sleep

Pause on sub-second sleeps

Author: rsamoilov

lib/rage/fiber_scheduler.rb

@@ -63,6 +63,7 @@ def io_write(io, buffer, length, offset = 0)
 
   def kernel_sleep(duration = nil)
     block(nil, duration || 0)
+    Fiber.pause if duration.nil? || duration < 1
   end
 
   # TODO: GC works a little strange with this closure;

spec/fiber_scheduler_spec.rb

@@ -338,4 +338,22 @@
       -> { expect((1..1.5)).to include(result) }
     end
   end
+
+  it "correctly sleeps with 0" do
+    within_reactor do
+      Fiber.await(Fiber.schedule { sleep(0) })
+      -> {}
+    rescue => e
+      -> { raise e }
+    end
+  end
+
+  it "correctly sleeps with no arguments" do
+    within_reactor do
+      Fiber.await(Fiber.schedule { sleep })
+      -> {}
+    rescue => e
+      -> { raise e }
+    end
+  end
 end

spec/integration/integration_spec.rb

@@ -155,6 +155,11 @@
       expect(response.code).to eq(500)
       expect(response.to_s).to include("raised from inner fiber")
     end
+
+    it "corrrectly processes short sleep calls" do
+      response = HTTP.get("http://localhost:3000/async/short_sleep")
+      expect(response.code).to eq(200)
+    end
   end
 
   context "with before actions" do

spec/integration/test_app/app/controllers/async_controller.rb

@@ -28,4 +28,9 @@ def raise_error
     end
     Fiber.await f
   end
+
+  def short_sleep
+    sleep 0.0001
+    head :ok
+  end
 end

spec/integration/test_app/config/routes.rb

@@ -19,6 +19,7 @@
   get "async/long", to: "async#long"
   get "async/empty", to: "async#empty"
   get "async/raise_error", to: "async#raise_error"
+  get "async/short_sleep", to: "async#short_sleep"
 
   get "before_actions/get", to: "before_actions#get"