Reset active status when setting a new value for cluster scheduled

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>

Author: 0xavi0

internal/cmd/controller/reconciler/schedule_controller.go

@@ -265,16 +265,19 @@ func setClusterScheduled(ctx context.Context, c client.Client, name, namespace s
 		return fmt.Errorf("%w, getting cluster: %w", fleetutil.ErrRetryable, err)
 	}
 
-	// if the value is already the expected one, avoid the update
-	if cluster.Status.Scheduled == scheduled {
+	// if the values are already the expected ones, avoid the update
+	if cluster.Status.Scheduled == scheduled && !cluster.Status.ActiveSchedule {
 		return nil
 	}
 
 	old := cluster.DeepCopy()
 	cluster.Status.Scheduled = scheduled
-	if !scheduled {
-		cluster.Status.ActiveSchedule = false
-	}
+
+	// when this function is called is either because we're updating a
+	// Schedule or because we're creating it.
+	// In both cases ActiveSchedule should be false as a Schedule
+	// always begins in OffSchedule mode until the first start call is executed.
+	cluster.Status.ActiveSchedule = false
 
 	return updateClusterStatus(ctx, c, old, cluster)
 }
@@ -413,10 +416,11 @@ func setClustersScheduled(ctx context.Context, c client.Client, clusters []strin
 func updateScheduledClusters(ctx context.Context, scheduler quartz.Scheduler, c client.Client, clustersNew []string, clustersOld []string, namespace string) error {
 	// first look for clusters that are not scheduled yet and flag them as scheduled
 	for _, cluster := range clustersNew {
-		if !slices.Contains(clustersOld, cluster) {
-			if err := setClusterScheduled(ctx, c, cluster, namespace, true); err != nil {
-				return err
-			}
+		// set schedule to true and also reset the activeSchedule property
+		// When we update a Schedule it begins from a offSchedule status until
+		// executeStart is called.
+		if err := setClusterScheduled(ctx, c, cluster, namespace, true); err != nil {
+			return err
 		}
 	}