Skip to content

Commit f7f55ab

Browse files
committed
Breakout Annotations E2E into 2 groups
Signed-off-by: Derek Nola <derek.nola@suse.com>
1 parent 450a843 commit f7f55ab

9 files changed

Lines changed: 16 additions & 10 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ jobs:
7272
fail-fast: true
7373
matrix:
7474
focus:
75-
- Annotations
76-
- Settings
75+
- Annotations_B
76+
- "Annotations_A|Settings"
7777
- "Admission|Cgroups|Default Backend|Disable Leader|Endpointslices|Flag|TCP"
7878
- "Ingress|Lua|Memory Leak|metrics|Security|Service|Shutdown|SSL|Status|TopologyHints"
7979
steps:

test/e2e/annotations/affinity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const (
4040
defaultHost = "foo.com"
4141
)
4242

43-
var _ = framework.DescribeAnnotation("affinity session-cookie-name", func() {
43+
var _ = framework.DescribeAnnotationB("affinity session-cookie-name", func() {
4444
f := framework.NewDefaultFramework("affinity")
4545

4646
ginkgo.BeforeEach(func() {

test/e2e/annotations/affinitymode.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030

3131
const sslRedirectValue = "false"
3232

33-
var _ = framework.DescribeAnnotation("affinitymode", func() {
33+
var _ = framework.DescribeAnnotationB("affinitymode", func() {
3434
f := framework.NewDefaultFramework("affinity")
3535

3636
ginkgo.It("Balanced affinity mode should balance", func() {

test/e2e/annotations/alias.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import (
2828

2929
const fooHost = "foo"
3030

31-
var _ = framework.DescribeAnnotation("server-alias", func() {
31+
var _ = framework.DescribeAnnotationB("server-alias", func() {
3232
f := framework.NewDefaultFramework("alias")
3333

3434
ginkgo.BeforeEach(func() {

test/e2e/annotations/approot.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"k8s.io/ingress-nginx/test/e2e/framework"
2626
)
2727

28-
var _ = framework.DescribeAnnotation("app-root", func() {
28+
var _ = framework.DescribeAnnotationB("app-root", func() {
2929
f := framework.NewDefaultFramework("approot")
3030

3131
ginkgo.BeforeEach(func() {

test/e2e/annotations/auth.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const (
4242
authURL = "http://foo.bar.baz:5000/path"
4343
)
4444

45-
var _ = framework.DescribeAnnotation("auth-*", func() {
45+
var _ = framework.DescribeAnnotationB("auth-*", func() {
4646
f := framework.NewDefaultFramework("auth", framework.WithHTTPBunEnabled())
4747

4848
ginkgo.BeforeEach(func() {

test/e2e/annotations/authtls.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import (
2828

2929
const authTLSFooHost = "authtls.foo.com"
3030

31-
var _ = framework.DescribeAnnotation("auth-tls-*", func() {
31+
var _ = framework.DescribeAnnotationB("auth-tls-*", func() {
3232
f := framework.NewDefaultFramework("authtls")
3333

3434
ginkgo.BeforeEach(func() {

test/e2e/annotations/modsecurity/modsecurity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const (
3636
SecRule REQUEST_HEADERS:User-Agent \"block-ua\" \"log,deny,id:107,status:403,msg:\'UA blocked\'\"`
3737
)
3838

39-
var _ = framework.DescribeAnnotation("modsecurity owasp", func() {
39+
var _ = framework.DescribeAnnotationB("modsecurity owasp", func() {
4040
f := framework.NewDefaultFramework("modsecuritylocation")
4141

4242
ginkgo.BeforeEach(func() {

test/e2e/framework/framework.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,13 @@ func IngressNginxDescribeSerial(text string, body func()) bool {
225225

226226
// DescribeAnnotation wrapper function for ginkgo describe. Adds namespacing.
227227
func DescribeAnnotation(text string, body func()) bool {
228-
return ginkgo.Describe("[Annotations] "+text, body)
228+
return ginkgo.Describe("[Annotations_A] "+text, body)
229+
}
230+
231+
// DescribeAnnotationB wrapper function for ginkgo describe. Adds namespacing.
232+
// Used to breakup annotation into smaller test groups
233+
func DescribeAnnotationB(text string, body func()) bool {
234+
return ginkgo.Describe("[Annotations_B] "+text, body)
229235
}
230236

231237
// DescribeSetting wrapper function for ginkgo describe. Adds namespacing.

0 commit comments

Comments
 (0)