Merge pull request #4957 from randombit/jack/fix-clang-tidy-hicpp-explicit-conversions

Enable and fix clang-tidy hicpp-explicit-conversions warning

Author: randombit

src/.clang-tidy

@@ -25,7 +25,6 @@ Checks: >
     -cppcoreguidelines-init-variables,
     -cppcoreguidelines-owning-memory,
     -cppcoreguidelines-prefer-member-initializer,
-    -hicpp-explicit-conversions,
     -misc-const-correctness,
     -misc-include-cleaner,
     -misc-redundant-expression,

src/bogo_shim/bogo_shim.cpp

@@ -347,7 +347,7 @@ std::string map_to_bogo_error(const std::string& e) noexcept {
 
 class Shim_Exception final : public std::exception {
    public:
-      Shim_Exception(std::string_view msg, int rc = 1) : m_msg(msg), m_rc(rc) {}
+      explicit Shim_Exception(std::string_view msg, int rc = 1) : m_msg(msg), m_rc(rc) {}
 
       const char* what() const noexcept override { return m_msg.c_str(); }
 
@@ -866,7 +866,7 @@ std::unique_ptr<Shim_Arguments> parse_options(char* argv[]) {
 
 class Shim_Policy final : public Botan::TLS::Policy {
    public:
-      Shim_Policy(const Shim_Arguments& args) : m_args(args), m_sessions(0) {}
+      explicit Shim_Policy(const Shim_Arguments& args) : m_args(args), m_sessions(0) {}
 
       void incr_session_established() { m_sessions += 1; }
 
@@ -1244,7 +1244,7 @@ std::vector<uint16_t> Shim_Policy::ciphersuite_list(Botan::TLS::Protocol_Version
 
 class Shim_Credentials final : public Botan::Credentials_Manager {
    public:
-      Shim_Credentials(const Shim_Arguments& args) : m_args(args) {
+      explicit Shim_Credentials(const Shim_Arguments& args) : m_args(args) {
          const auto psk_identity = m_args.get_string_opt_or_else("psk-identity", "");
          const auto psk_str = m_args.get_string_opt_or_else("psk", "");
 

src/cli/perf_sym.cpp

@@ -40,7 +40,7 @@ namespace Botan_CLI {
 #if defined(BOTAN_HAS_BLOCK_CIPHER)
 class PerfTest_BlockCipher final : public PerfTest {
    public:
-      PerfTest_BlockCipher(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_BlockCipher(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::BlockCipher::providers(m_alg)) {
@@ -104,7 +104,7 @@ class PerfTest_BlockCipher final : public PerfTest {
 #if defined(BOTAN_HAS_CIPHER_MODES)
 class PerfTest_CipherMode final : public PerfTest {
    public:
-      PerfTest_CipherMode(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_CipherMode(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::Cipher_Mode::providers(m_alg)) {
@@ -184,7 +184,7 @@ class PerfTest_CipherMode final : public PerfTest {
 #if defined(BOTAN_HAS_STREAM_CIPHER)
 class PerfTest_StreamCipher final : public PerfTest {
    public:
-      PerfTest_StreamCipher(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_StreamCipher(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::StreamCipher::providers(m_alg)) {
@@ -247,7 +247,7 @@ class PerfTest_StreamCipher final : public PerfTest {
 #if defined(BOTAN_HAS_HASH)
 class PerfTest_HashFunction final : public PerfTest {
    public:
-      PerfTest_HashFunction(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_HashFunction(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::HashFunction::providers(m_alg)) {
@@ -288,7 +288,7 @@ class PerfTest_HashFunction final : public PerfTest {
 #if defined(BOTAN_HAS_MAC)
 class PerfTest_MessageAuthenticationCode final : public PerfTest {
    public:
-      PerfTest_MessageAuthenticationCode(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_MessageAuthenticationCode(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::MessageAuthenticationCode::providers(m_alg)) {
@@ -339,7 +339,7 @@ class PerfTest_MessageAuthenticationCode final : public PerfTest {
 #if defined(BOTAN_HAS_XOF)
 class PerfTest_XOF final : public PerfTest {
    public:
-      PerfTest_XOF(std::string_view alg) : m_alg(alg) {}
+      explicit PerfTest_XOF(std::string_view alg) : m_alg(alg) {}
 
       void go(const PerfConfig& config) override {
          for(const auto& provider : Botan::XOF::providers(m_alg)) {

src/cli/psk.cpp

@@ -16,8 +16,6 @@ namespace Botan_CLI {
 
 class PSK_Tool_Base : public Command {
    public:
-      PSK_Tool_Base(const std::string& spec) : Command(spec) {}
-
       std::string group() const override { return "psk"; }
 
       void go() override {
@@ -31,6 +29,9 @@ class PSK_Tool_Base : public Command {
          psk_operation(psk);
       }
 
+   protected:
+      explicit PSK_Tool_Base(const std::string& spec) : Command(spec) {}
+
    private:
       virtual void psk_operation(Botan::PSK_Database& db) = 0;
 };

src/cli/timer.h

@@ -23,7 +23,7 @@ class Timer final {
             double clock_cycle_ratio,
             uint64_t clock_speed);
 
-      Timer(std::string_view name) : Timer(name, "", "", 1, 0, 0.0, 0) {}
+      explicit Timer(std::string_view name) : Timer(name, "", "", 1, 0, 0.0, 0) {}
 
       Timer(std::string_view name, size_t buf_size) : Timer(name, "", "", buf_size, buf_size, 0.0, 0) {}
 

src/cli/tls_client.cpp

@@ -42,7 +42,7 @@ namespace {
 
 class Callbacks : public Botan::TLS::Callbacks {
    public:
-      Callbacks(TLS_Client& client_command) : m_client_command(client_command), m_peer_closed(false) {}
+      explicit Callbacks(TLS_Client& client_command) : m_client_command(client_command), m_peer_closed(false) {}
 
       std::ostream& output();
       bool flag_set(const std::string& flag_name) const;

src/cli/tls_server.cpp

@@ -51,7 +51,7 @@ namespace {
 
 class Callbacks : public Botan::TLS::Callbacks {
    public:
-      Callbacks(TLS_Server& server_command) : m_server_command(server_command) {}
+      explicit Callbacks(TLS_Server& server_command) : m_server_command(server_command) {}
 
       std::ostream& output();
       void send(std::span<const uint8_t> buffer);

src/examples/fpe_dictionary.cpp

@@ -6,7 +6,7 @@
 
 class Dictionary {
    public:
-      Dictionary(const std::string& filename) {
+      explicit Dictionary(const std::string& filename) {
          std::ifstream in(filename);
 
          while(in.good()) {

src/examples/tls_ssl_key_log_file.cpp

@@ -111,7 +111,7 @@ class BotanTLSCallbacksProxy : public Botan::TLS::Callbacks {
       Botan::TLS::Callbacks& parent;
 
    public:
-      BotanTLSCallbacksProxy(Botan::TLS::Callbacks& callbacks) : parent(callbacks) {}
+      explicit BotanTLSCallbacksProxy(Botan::TLS::Callbacks& callbacks) : parent(callbacks) {}
 
       void tls_emit_data(std::span<const uint8_t> data) override { parent.tls_emit_data(data); }
 

src/examples/tls_stream_client.cpp

@@ -44,7 +44,7 @@ class client {
                                                         std::make_shared<Botan::AutoSeeded_RNG>(),
                                                         std::make_shared<Botan::TLS::Session_Manager_Noop>(),
                                                         std::make_shared<Botan::TLS::Policy>(),
-                                                        host)),
+                                                        Botan::TLS::Server_Information(host))),
             m_stream(io_context, m_ctx) {
          boost::asio::async_connect(m_stream.lowest_layer(),
                                     endpoints.begin(),