Skip to content

Commit a78ca6e

Browse files
committed
Instruct testing to stash before testing new tests
1 parent 529b1f6 commit a78ca6e

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

  • .agents/skills/review-cudf-polars-expressions

.agents/skills/review-cudf-polars-expressions/SKILL.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,15 @@ TODO: Add more guidance on a multiple partition implementation.
7979

8080
## Step 4: Test the Polars expression implementation in cudf-polars
8181

82-
Finally, add a unit test to an existing or new file in the `python/cudf_polars/tests/expressions` directory to test the implementation.
82+
Finally, add unit tests to an existing or new file in the `python/cudf_polars/tests/expressions` directory to test the implementation.
8383

8484
1. The added unit tests should cover all the lines added in the implementation. A CI job validates that there is 100% code coverage.
8585
2. The unit tests should use the `engine` fixture from `python/cudf_polars/tests/conftest.py` to test all applicable cudf-polars engine types including single and multiple partition execution.
8686
3. Review the existing unit tests in `python/cudf_polars/tests` to check if existing tests used this expressions. Unit tests may have existed that asserted that this expression was not supported.
8787
4. The unit test should use `pytest.mark.skipif` with a boolean variable from `python/cudf_polars/cudf_polars/utils/versions.py` if a unit test exercises a Polars expression or an argument that doesn't exist since a particular Polars version within the cudf-polars support window defined in `python/cudf_polars/pyproject.toml`.
8888
5. When using `assert_gpu_result_equal` for expressions that return floats, consider specifying `check_exact=False` if necessary.
8989

90-
TODO: Add more guidance on a multiple partition implementation.
90+
When running the unit tests:
91+
92+
1. First, `git stash` the new implementation (i.e. all changes not in `python/cudf_polars/tests`) and only run the newly added tests to validate they fail without the new implementation.
93+
2. Next, `git stash apply` the stashed files and run *all* unit tests in `python/cudf_polars/tests`. Address failures from the newly added tests or existing tests that fail because they use the Polars expressions being implemented.

0 commit comments

Comments
 (0)