Skip to content

Commit e2de0fa

Browse files
authored
Merge branch 'main' into test-mr-pr/01-foundation
2 parents 14a3829 + bd5e3cc commit e2de0fa

60 files changed

Lines changed: 2352 additions & 368 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

conda/environments/all_cuda-129_arch-aarch64.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ dependencies:
1717
- cmake>=4.0
1818
- cramjam
1919
- croaring==4.4.2
20+
- cuda-bindings>=12.9.2,<13.0
2021
- cuda-cudart-dev
2122
- cuda-cupti-dev
2223
- cuda-nvcc
2324
- cuda-nvrtc-dev
2425
- cuda-nvtx-dev
25-
- cuda-python>=12.9.2,<13.0
2626
- cuda-sanitizer-api
2727
- cuda-version=12.9
2828
- cupy>=14.0.1,!=14.1.0

conda/environments/all_cuda-129_arch-x86_64.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ dependencies:
1717
- cmake>=4.0
1818
- cramjam
1919
- croaring==4.4.2
20+
- cuda-bindings>=12.9.2,<13.0
2021
- cuda-cudart-dev
2122
- cuda-cupti-dev
2223
- cuda-nvcc
2324
- cuda-nvrtc-dev
2425
- cuda-nvtx-dev
25-
- cuda-python>=12.9.2,<13.0
2626
- cuda-sanitizer-api
2727
- cuda-version=12.9
2828
- cupy>=14.0.1,!=14.1.0

conda/environments/all_cuda-133_arch-aarch64.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ dependencies:
1717
- cmake>=4.0
1818
- cramjam
1919
- croaring==4.4.2
20+
- cuda-bindings>=13.0.1,<14.0
2021
- cuda-cudart-dev
2122
- cuda-cupti-dev
2223
- cuda-nvcc
2324
- cuda-nvrtc-dev
2425
- cuda-nvtx-dev
25-
- cuda-python>=13.0.1,<14.0
2626
- cuda-sanitizer-api
2727
- cuda-version=13.3
2828
- cupy>=14.0.1,!=14.1.0

conda/environments/all_cuda-133_arch-x86_64.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ dependencies:
1717
- cmake>=4.0
1818
- cramjam
1919
- croaring==4.4.2
20+
- cuda-bindings>=13.0.1,<14.0
2021
- cuda-cudart-dev
2122
- cuda-cupti-dev
2223
- cuda-nvcc
2324
- cuda-nvrtc-dev
2425
- cuda-nvtx-dev
25-
- cuda-python>=13.0.1,<14.0
2626
- cuda-sanitizer-api
2727
- cuda-version=13.3
2828
- cupy>=14.0.1,!=14.1.0

conda/recipes/cudf-polars/recipe.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ requirements:
4242
- packaging
4343
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }}
4444
- if: cuda_major == "12"
45-
then: cuda-python >=12.9.2,<13.0
46-
else: cuda-python >=13.0.1,<14.0
45+
then: cuda-bindings >=12.9.2,<13.0
46+
else: cuda-bindings >=13.0.1,<14.0
4747
run_constraints:
4848
- ray-default >=2.55.1
4949
ignore_run_exports:

conda/recipes/cudf/recipe.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ requirements:
102102
- ${{ pin_compatible("rmm", upper_bound="x.x") }}
103103
- fsspec >=0.6.0
104104
- if: cuda_major == "12"
105-
then: cuda-python >=12.9.2,<13.0
106-
else: cuda-python >=13.0.1,<14.0
105+
then: cuda-bindings >=12.9.2,<13.0
106+
else: cuda-bindings >=13.0.1,<14.0
107107
- if: linux and x86_64
108108
then:
109109
- libcufile

conda/recipes/pylibcudf/recipe.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ requirements:
9090
- libcudf =${{ version }}
9191
- ${{ pin_compatible("rmm", upper_bound="x.x") }}
9292
- if: cuda_major == "12"
93-
then: cuda-python >=12.9.2,<13.0
94-
else: cuda-python >=13.0.1,<14.0
93+
then: cuda-bindings >=12.9.2,<13.0
94+
else: cuda-bindings >=13.0.1,<14.0
9595
- nvtx >=0.2.1
9696
run_constraints:
9797
- numpy >=2.0,<3.0

cpp/benchmarks/reshape/interleave.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
/*
2-
* SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
2+
* SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

66
#include <benchmarks/common/generate_input.hpp>
77
#include <benchmarks/common/memory_stats.hpp>
88

99
#include <cudf/reshape.hpp>
10-
#include <cudf/strings/strings_column_view.hpp>
1110
#include <cudf/utilities/default_stream.hpp>
1211

1312
#include <nvbench/nvbench.cuh>
@@ -33,10 +32,9 @@ static void bench_interleave(nvbench::state& state)
3332
auto const stream = cudf::get_default_stream();
3433

3534
state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value()));
36-
auto chars_size = cudf::strings_column_view(source_view.column(0)).chars_size(stream) +
37-
cudf::strings_column_view(source_view.column(1)).chars_size(stream);
38-
state.add_global_memory_reads<nvbench::int8_t>(chars_size); // all bytes are read
39-
state.add_global_memory_writes<nvbench::int8_t>(chars_size); // all bytes are written
35+
auto input_bytes = source_table->alloc_size();
36+
state.add_global_memory_reads<nvbench::int8_t>(input_bytes); // all bytes are read
37+
state.add_global_memory_writes<nvbench::int8_t>(input_bytes); // all bytes are written
4038

4139
auto const mem_stats_logger = cudf::memory_stats_logger();
4240
state.exec(nvbench::exec_tag::sync, [&](nvbench::launch& launch) {

cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <rapidsmpf/bootstrap/bootstrap.hpp>
99
#include <rapidsmpf/bootstrap/utils.hpp>
1010
#include <rapidsmpf/communicator/communicator.hpp>
11+
#include <rapidsmpf/communicator/logger.hpp>
1112
#include <rapidsmpf/error.hpp>
1213
#include <rapidsmpf/memory/spill.hpp>
1314
#include <rapidsmpf/nvtx.hpp>
@@ -516,6 +517,8 @@ int main(int argc, char** argv)
516517
auto& stat_enabled_mr = br->device_mr_adaptor();
517518
rmm::mr::set_current_device_resource(stat_enabled_mr);
518519

520+
auto log = rapidsmpf::Logger::from_options(options);
521+
519522
std::shared_ptr<rapidsmpf::Communicator> comm;
520523
auto progress_thread = std::make_shared<rapidsmpf::ProgressThread>(stats);
521524
if (args.comm_type == "mpi") {
@@ -527,7 +530,7 @@ int main(int argc, char** argv)
527530
return 1;
528531
}
529532
rapidsmpf::mpi::init(&argc, &argv);
530-
comm = std::make_shared<rapidsmpf::MPI>(MPI_COMM_WORLD, options, progress_thread);
533+
comm = std::make_shared<rapidsmpf::MPI>(MPI_COMM_WORLD, progress_thread, log);
531534
#else
532535
std::cerr << "Error: MPI communicator is not available in this build." << std::endl;
533536
return 1;
@@ -537,11 +540,11 @@ int main(int argc, char** argv)
537540
if (use_bootstrap) {
538541
// Launched with rrun - use bootstrap backend
539542
comm = rapidsmpf::bootstrap::create_ucxx_comm(
540-
progress_thread, rapidsmpf::bootstrap::BackendType::AUTO, options);
543+
progress_thread, rapidsmpf::bootstrap::BackendType::AUTO, options, log);
541544
} else {
542545
#ifdef CUDF_STREAMING_HAVE_MPI
543546
// Launched with mpirun - use MPI bootstrap
544-
comm = rapidsmpf::ucxx::init_using_mpi(MPI_COMM_WORLD, options, progress_thread);
547+
comm = rapidsmpf::ucxx::init_using_mpi(MPI_COMM_WORLD, options, progress_thread, log);
545548
#else
546549
std::cerr << "Error: UCXX without MPI support requires bootstrap mode." << std::endl;
547550
return 1;
@@ -558,7 +561,6 @@ int main(int argc, char** argv)
558561

559562
args.pprint(*comm);
560563

561-
auto& log = comm->logger();
562564
rmm::cuda_stream_view stream = cudf::get_default_stream();
563565

564566
// Print benchmark/hardware info.

cpp/libcudf_streaming/benchmarks/streaming/bench_streaming_shuffle.cpp

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include <rapidsmpf/bootstrap/bootstrap.hpp>
1616
#include <rapidsmpf/bootstrap/utils.hpp>
1717
#include <rapidsmpf/communicator/communicator.hpp>
18+
#include <rapidsmpf/communicator/logger.hpp>
1819
#include <rapidsmpf/error.hpp>
1920
#include <rapidsmpf/nvtx.hpp>
2021
#include <rapidsmpf/shuffler/shuffler.hpp>
@@ -276,6 +277,7 @@ int main(int argc, char** argv)
276277

277278
// Initialize configuration options from environment variables.
278279
rapidsmpf::config::Options options{rapidsmpf::config::get_environment_variables()};
280+
auto log = rapidsmpf::Logger::from_options(options);
279281
auto progress_thread = std::make_shared<rapidsmpf::ProgressThread>();
280282

281283
std::shared_ptr<rapidsmpf::Communicator> comm;
@@ -288,7 +290,7 @@ int main(int argc, char** argv)
288290
return 1;
289291
}
290292
rapidsmpf::mpi::init(&argc, &argv);
291-
comm = std::make_shared<rapidsmpf::MPI>(MPI_COMM_WORLD, options, progress_thread);
293+
comm = std::make_shared<rapidsmpf::MPI>(MPI_COMM_WORLD, progress_thread, log);
292294
#else
293295
std::cerr << "Error: MPI communicator is not available in this build." << std::endl;
294296
return 1;
@@ -298,11 +300,11 @@ int main(int argc, char** argv)
298300
if (use_bootstrap) {
299301
// Launched with rrun - use bootstrap backend
300302
comm = rapidsmpf::bootstrap::create_ucxx_comm(
301-
progress_thread, rapidsmpf::bootstrap::BackendType::AUTO, options);
303+
progress_thread, rapidsmpf::bootstrap::BackendType::AUTO, options, log);
302304
} else {
303305
#ifdef CUDF_STREAMING_HAVE_MPI
304306
// Launched with mpirun - use MPI bootstrap
305-
comm = rapidsmpf::ucxx::init_using_mpi(MPI_COMM_WORLD, options, progress_thread);
307+
comm = rapidsmpf::ucxx::init_using_mpi(MPI_COMM_WORLD, options, progress_thread, log);
306308
#else
307309
std::cerr << "Error: UCXX without MPI support requires bootstrap mode." << std::endl;
308310
return 1;
@@ -344,7 +346,6 @@ int main(int argc, char** argv)
344346
auto& stat_enabled_mr = br->device_mr_adaptor();
345347
rmm::mr::set_current_device_resource(stat_enabled_mr);
346348

347-
auto& log = *comm->logger();
348349
rmm::cuda_stream_view stream = cudf::get_default_stream();
349350

350351
// Print benchmark/hardware info.
@@ -361,7 +362,7 @@ int main(int argc, char** argv)
361362
ss << " PCI Bus ID: " << pci_bus_id.substr(0, pci_bus_id.find('\0')) << "\n";
362363
ss << " Total Memory: " << rapidsmpf::format_nbytes(properties.totalGlobalMem, 0) << "\n";
363364
ss << " Comm: " << *comm << "\n";
364-
log.print(ss.str());
365+
log->print(ss.str());
365366
}
366367

367368
auto ctx = std::make_shared<rapidsmpf::streaming::Context>(options, comm->logger(), br);
@@ -378,7 +379,7 @@ int main(int argc, char** argv)
378379
<< "/s | global throughput: " << rapidsmpf::format_nbytes(args.total_nbytes / elapsed)
379380
<< "/s";
380381
if (i < args.num_warmups) { ss << " (warmup run)"; }
381-
log.print(ss.str());
382+
log->print(ss.str());
382383
if (i >= args.num_warmups) { elapsed_vec.push_back(elapsed); }
383384
}
384385

@@ -417,18 +418,18 @@ int main(int argc, char** argv)
417418
<< rapidsmpf::format_nbytes(record.total() / static_cast<std::int64_t>(total_num_runs))
418419
<< " (avg)";
419420
}
420-
log.print(ss.str());
421+
log->print(ss.str());
421422
}
422423

423424
auto statistics = ctx->statistics();
424425
if (args.enable_memory_profiler) {
425-
log.print(statistics->report({
426+
log->print(statistics->report({
426427
.mr = stat_enabled_mr,
427428
.pinned_mr = pinned_mr,
428429
.header = "Statistics (of the last run):",
429430
}));
430431
} else {
431-
log.print(statistics->report({.header = "Statistics (of the last run):"}));
432+
log->print(statistics->report({.header = "Statistics (of the last run):"}));
432433
}
433434

434435
#ifdef CUDF_STREAMING_HAVE_MPI

0 commit comments

Comments
 (0)