Commit febe16f
committed
net: bcmgenet: restore PHY power management flags
Restore PHY_BRCM_AUTO_PWRDWN_ENABLE, PHY_BRCM_DIS_TXCRXC_NOENRGY and
PHY_BRCM_IDDQ_SUSPEND in bcmgenet_mii_probe(), reverting the
downstream hunk that snuck into 7dd290a ("xhci: add quirk...")
back in March 2022.
That hunk worked around raspberrypi/rpi-eeprom#417: on Pi 4B rev 1.1
only, the bootloader couldn't recover the PHY from IDDQ-SR after a
kernel reboot. CM4 and newer Pi 4B revs were never affected. The
rpi-eeprom fix shipped in April 2022 (release c68f0c06) and the issue
was closed a month later.
With the bootloader fix ~4 years deployed, drop the kernel-side
workaround and get back the "several hundreds of milliwatts" of idle
power savings Florian quoted in the issue thread.
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>1 parent 95b85be commit febe16f
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | | - | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
310 | 312 | | |
311 | 313 | | |
312 | 314 | | |
| |||
0 commit comments