Re-trigger CI

Signed-off-by: john.taylor <john.taylor@anyscale.com>

Author: johntaylor-cell

python/ray/serve/_private/deployment_state.py

@@ -2177,7 +2177,7 @@ def _memoized_walk(obj, memo_attr: str, token, compute):
     token=None means "uncacheable right now": recompute and drop the memo.
     Callers must treat returned collections as immutable (they are shared).
     """
-    memo = getattr(obj, memo_attr)
+    memo = getattr(obj, memo_attr, None)
     if token is not None and memo is not None and memo[0] == token:
         return memo[1]
     result = compute()
@@ -2200,7 +2200,7 @@ def __init__(self, on_replica_state_change=None):
 
     @property
     def mutation_version(self) -> int:
-        return self._mutation_version
+        return getattr(self, "_mutation_version", 0)
 
     def __getstate__(self):
         # Exclude the callback to keep the container picklable (the callback
@@ -2224,7 +2224,7 @@ def add(self, state: ReplicaState, replica: DeploymentReplica):
         self._replicas[state].append(replica)
         self._replica_id_index[replica.replica_id] = replica
         self._sv_counts[(state, replica.version)] += 1
-        self._mutation_version += 1
+        self._mutation_version = getattr(self, "_mutation_version", 0) + 1
         if self._on_replica_state_change and state != old_state:
             self._on_replica_state_change(old_state, state)
 
@@ -2323,7 +2323,7 @@ def pop(
             self._replica_id_index.pop(replica.replica_id, None)
 
         if replicas:
-            self._mutation_version += 1
+            self._mutation_version = getattr(self, "_mutation_version", 0) + 1
         return replicas
 
     def count(
@@ -2398,7 +2398,7 @@ def remove(self, replica_ids: Set[ReplicaID]) -> List[DeploymentReplica]:
             if found_any:
                 self._replicas[state] = remaining
         if removed:
-            self._mutation_version += 1
+            self._mutation_version = getattr(self, "_mutation_version", 0) + 1
         return removed
 
     def __str__(self):
@@ -3368,20 +3368,20 @@ def get_alive_replica_actor_ids(self) -> Set[str]:
             self,
             "_alive_replica_actor_ids_memo",
             self._membership_cache_token(),
-            lambda: {replica.actor_id for replica in self._replicas.get()},
+            lambda: frozenset(replica.actor_id for replica in self._replicas.get()),
         )
 
     def get_running_replica_ids(self) -> List[ReplicaID]:
         return _memoized_walk(
             self,
             "_running_replica_ids_memo",
             self._membership_cache_token(),
-            lambda: [
+            lambda: tuple(
                 replica.replica_id
                 for replica in self._replicas.get(
                     [ReplicaState.RUNNING, ReplicaState.PENDING_MIGRATION]
                 )
-            ],
+            ),
         )
 
     def get_running_replica_infos(self) -> List[RunningReplicaInfo]:
@@ -3438,11 +3438,11 @@ def get_active_node_ids(self) -> Set[str]:
             self,
             "_active_node_ids_memo",
             self._membership_cache_token(),
-            lambda: {
+            lambda: frozenset(
                 replica.actor_node_id
                 for replica in self._replicas.get(active_states)
                 if replica.actor_node_id is not None
-            },
+            ),
         )
 
     def list_replica_details(self) -> List[ReplicaDetails]:
@@ -5060,10 +5060,11 @@ def _maybe_check_rank_consistency(self) -> None:
         ):
             return
         version = self._replicas.mutation_version
-        if version == self._last_rank_membership_version:
+        if version == getattr(self, "_last_rank_membership_version", None):
             return
         active_replicas = self._replicas.get()
         if not active_replicas:
+            self._last_rank_membership_version = version
             return
         replicas_to_reconfigure = (
             self._rank_manager.check_rank_consistency_and_reassign_minimally(

python/ray/serve/tests/unit/test_deployment_state.py

@@ -10262,7 +10262,9 @@ def test_getters_memoize_and_invalidate_on_mutation(self):
         ds = self._ds()
         ds._replicas.add(ReplicaState.RUNNING, self._replica("r1"))
         ids1 = ds.get_running_replica_ids()
-        assert ids1 == ["r1"]
+        assert tuple(ids1) == (
+            "r1",
+        )  # cached collections are immutable (tuple/frozenset)
         assert ds.get_running_replica_ids() is ids1  # cache hit
         assert ds.get_alive_replica_actor_ids() == {"actor-r1"}
         assert ds.get_active_node_ids() == {"node-r1"}