Rename autoscaling metric test variants for what they now do

With controller aggregation the only mode, "metr_agg_at_controller" no longer
distinguishes anything. Name each variant by the collection site it actually
configures: COLLECT_AUTOSCALING_METRICS_ON_HANDLE=0 collects on replicas, and the
flag defaults to 1, so an unset variant collects on handles.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: John Taylor <john.taylor@anyscale.com>

Author: johntaylor-cell

python/ray/serve/tests/BUILD.bazel

@@ -34,13 +34,13 @@ py_test_module_list(
 py_test_module_list_with_env_variants(
     size = "medium",
     env_variants = {
-        "metr_agg_at_controller": {
+        "metr_collect_on_replica": {
             "env": {
                 "RAY_SERVE_COLLECT_AUTOSCALING_METRICS_ON_HANDLE": "0",
                 "RAY_SERVE_AUTOSCALING_METRIC_RECORD_INTERVAL_FACTOR": "0.001",
                 "RAY_SERVE_RECORD_AUTOSCALING_STATS_TIMEOUT_S": "3",
             },
-            "name_suffix": "_metr_agg_at_controller",
+            "name_suffix": "_metr_collect_on_replica",
         },
     },
     files = [
@@ -556,12 +556,12 @@ AUTOSCALING_METRIC_ENV_VARIANTS = {
         },
         "name_suffix": "_metr_disab",
     },
-    "metr_agg_at_controller": {
+    "metr_collect_on_handle": {
         "env": {
             # Make sure queued metrics are cleared out quickly.
             "RAY_SERVE_HANDLE_AUTOSCALING_METRIC_PUSH_INTERVAL_S": "0.1",
         },
-        "name_suffix": "_metr_agg_at_controller",
+        "name_suffix": "_metr_collect_on_handle",
     },
 }
 

python/ray/serve/tests/unit/BUILD.bazel

@@ -80,12 +80,12 @@ py_test_module_list_with_env_variants(
             },
             "name_suffix": "_metr_disab",
         },
-        "metr_agg_at_controller": {
+        "metr_collect_on_handle": {
             "env": {
                 "RAY_SERVE_COLLECT_AUTOSCALING_METRICS_ON_HANDLE": "1",
                 "RAY_SERVE_FAIL_ON_RANK_ERROR": "1",
             },
-            "name_suffix": "_metr_agg_at_controller",
+            "name_suffix": "_metr_collect_on_handle",
         },
     },
     files = [