Commit 855d41b
committed
[ci] Fix docs-go scope guard to diff against the PR base branch
The docs-go scope guard computed its diff base as the merge-base with a
hardcoded origin/master. On a release-branch backport (base releases/X.Y),
that merge-base is where the release branch diverged from master, so the diff
includes every change that landed on the release branch but not master. A
genuinely content-only doc backport is then flagged with the release branch's
non-doc changes and the guard fails a valid PR.
Diff against ${BUILDKITE_PULL_REQUEST_BASE_BRANCH:-master} instead, matching
ci/lint/lint.sh and ci/pipeline/determine_tests_to_run.py. On a normal PR the
base is master and behavior is unchanged; on a backport it correctly scopes to
the files the PR actually adds.
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>1 parent 7a5d7f1 commit 855d41b
1 file changed
Lines changed: 12 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | 62 | | |
54 | 63 | | |
| |||
0 commit comments