Skip to content

Commit 92acd76

Browse files
authored
Apply suggestions from code review
Co-authored-by: Rueian <rueiancsie@gmail.com> Signed-off-by: Rueian <rueiancsie@gmail.com>
1 parent 8741298 commit 92acd76

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

python/ray/tests/test_gcs_pubsub.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ class ChannelStats(NamedTuple):
180180
class PublisherStats(NamedTuple):
181181
"""Current state of one publisher from the GCS debug dump."""
182182

183-
# Long-polling connections into the publisher. There is one per subscriber
183+
# Long-polling RPCs into the publisher. There is one per subscriber
184184
# process regardless of how many channels or keys it subscribes to, so this
185185
# is the channel-agnostic connection count.
186186
long_polling_subscribers: int
@@ -298,7 +298,7 @@ def f(self):
298298
# num_nodes raylets + the driver + the generator actor's worker + 2 from the
299299
# dashboard head. The dashboard counts twice because its node-info and actor
300300
# subscribers each mint their own subscriber id (see _SubscriberBase.__init__
301-
# in gcs_pubsub.py), so one process holds two long-poll connections.
301+
# in gcs_pubsub.py), so one process holds two long-poll RPCs.
302302
# The exact value matters less than the invariant it pins: it must not grow
303303
# with num_workers (verified unchanged at num_workers=6 and 12).
304304
expected_long_polling_subscribers = num_nodes + 4

src/ray/pubsub/publisher.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ std::string Publisher::DebugString() const {
559559
absl::MutexLock lock(&mutex_);
560560
std::stringstream result;
561561
result << "Publisher:";
562-
// Total long-polling connections into this publisher. One SubscriberState
562+
// Total long-polling RPCs into this publisher. One SubscriberState
563563
// per subscriber process, regardless of how many channels or keys it
564564
// subscribes to, so this is the channel-agnostic connection count.
565565
result << "\n- current long-polling subscribers: " << subscribers_.size();

0 commit comments

Comments
 (0)