Fix optional dependencies shifting dependency indices, allow nulls in dependency arrays #453
facebook-github-botbuild-test-and-deploy.yml
on: pull_request
Matrix: test
Type check, lint, smoke test
53s
Tests with coverage
1m 28s
Deploy
0s
Annotations
3 errors and 3 warnings
|
test (windows-latest, lts/*) / Tests [Node.js lts/*, windows-latest, Using yarn.lock]
Process completed with exit code 1.
|
|
test (windows-latest, lts/-1) / Tests [Node.js lts/-1, windows-latest, Using yarn.lock]
Process completed with exit code 1.
|
|
test (windows-latest, 18.18.0) / Tests [Node.js 18.18.0, windows-latest, Using yarn.lock]
Process completed with exit code 1.
|
|
Type check, lint, smoke test:
packages/metro-transform-plugins/src/import-export-plugin.js#L143
'withLocation' is already defined
|
|
Type check, lint, smoke test:
packages/metro-transform-plugins/src/addParamsToDefineCall.js#L26
Always use `== null` or `!= null` to check for `null` AND `undefined` values (even if you just expect either of them). Within fb we treat them as equal and `== null` checks for both
|
|
Type check, lint, smoke test:
packages/metro-minify-terser/src/__tests__/minify-test.js#L13
Requires should be sorted alphabetically, with at least one line between imports/requires and code
|