fix: reset maxDuration only after recording TracingStartedInPage event (#53080)

hoxyq · facebook-github-bot · commit 421a0c7077b9 · 2025-08-06T05:48:35.000-07:00
Summary: Pull Request resolved: #53080 # Changelog: [Internal] We were accidentally resetting this before calculating the timestampf for the TracingStartedInPage event, which is the left boundary for the timeline window. Reviewed By: sbuggay Differential Revision: D79670865 fbshipit-source-id: c6b5f869e185d6d3c80cb7153891c72283c82418
diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp
@@ -77,7 +77,6 @@ std::optional<std::vector<TraceEvent>> PerformanceTracer::stopTracing() {
 
     tracingAtomic_ = false;
     performanceMeasureCount_ = 0;
-    currentTraceMaxDuration_ = std::nullopt;
 
     events = collectEventsAndClearBuffers(currentTraceEndTime);
   }
@@ -114,6 +113,7 @@ std::optional<std::vector<TraceEvent>> PerformanceTracer::stopTracing() {
       .tid = oscompat::getCurrentThreadId(),
   });
 
+  currentTraceMaxDuration_ = std::nullopt;
   return events;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ std::optional<std::vector<TraceEvent>> PerformanceTracer::stopTracing() {`
`77`	`77`
`78`	`78`	`tracingAtomic_ = false;`
`79`	`79`	`performanceMeasureCount_ = 0;`
`80`		`- currentTraceMaxDuration_ = std::nullopt;`
`81`	`80`
`82`	`81`	`events = collectEventsAndClearBuffers(currentTraceEndTime);`
`83`	`82`	`}`
`@@ -114,6 +113,7 @@ std::optional<std::vector<TraceEvent>> PerformanceTracer::stopTracing() {`
`114`	`113`	`.tid = oscompat::getCurrentThreadId(),`
`115`	`114`	`});`
`116`	`115`
	`116`	`+ currentTraceMaxDuration_ = std::nullopt;`
`117`	`117`	`return events;`
`118`	`118`	`}`
`119`	`119`