Fix lint issues in SpringAnimation (#55364)

Summary:
Pull Request resolved: #55364

Fixed multiple lint issues in SpringAnimation.kt:

1. FieldsBelowInit: Moved isAtRest and isOvershooting computed properties
   above the init block to follow Kotlin initialization order conventions.

2. MixedConditionalOperators: Added explicit parentheses to clarify operator
   precedence in boolean expressions mixing && and ||.

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D91738503

fbshipit-source-id: 9968dc5c07f8a1023ef1f700f4dca26321a5692c

Author: mdvacca

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/SpringAnimation.kt

@@ -40,6 +40,24 @@ internal class SpringAnimation(config: ReadableMap) : AnimationDriver() {
   private var currentLoop = 0
   private var originalValue = 0.0
 
+  private val isAtRest: Boolean
+    /**
+     * check if the current state is at rest
+     *
+     * @return is the spring at rest
+     */
+    get() =
+        (abs(currentState.velocity) <= restSpeedThreshold &&
+            (getDisplacementDistanceForState(currentState) <= displacementFromRestThreshold ||
+                springStiffness == 0.0))
+
+  /* Check if the spring is overshooting beyond its target. */
+  private val isOvershooting: Boolean
+    get() =
+        (springStiffness > 0 &&
+            ((startValue < endValue && currentState.position > endValue) ||
+                (startValue > endValue && currentState.position < endValue)))
+
   init {
     currentState.velocity = config.getDouble("initialVelocity")
     resetConfig(config)
@@ -98,24 +116,6 @@ internal class SpringAnimation(config: ReadableMap) : AnimationDriver() {
   private fun getDisplacementDistanceForState(state: PhysicsState): Double =
       abs(endValue - state.position)
 
-  private val isAtRest: Boolean
-    /**
-     * check if the current state is at rest
-     *
-     * @return is the spring at rest
-     */
-    get() =
-        (abs(currentState.velocity) <= restSpeedThreshold &&
-            (getDisplacementDistanceForState(currentState) <= displacementFromRestThreshold ||
-                springStiffness == 0.0))
-
-  /* Check if the spring is overshooting beyond its target. */
-  private val isOvershooting: Boolean
-    get() =
-        (springStiffness > 0 &&
-            (startValue < endValue && currentState.position > endValue ||
-                startValue > endValue && currentState.position < endValue))
-
   private fun advance(realDeltaTime: Double) {
     if (isAtRest) {
       return
@@ -167,7 +167,7 @@ internal class SpringAnimation(config: ReadableMap) : AnimationDriver() {
     // End the spring immediately if it is overshooting and overshoot clamping is enabled.
     // Also make sure that if the spring was considered within a resting threshold that it's now
     // snapped to its end value.
-    if (isAtRest || overshootClampingEnabled && isOvershooting) {
+    if (isAtRest || (overshootClampingEnabled && isOvershooting)) {
       // Don't call setCurrentValue because that forces a call to onSpringUpdate
       if (springStiffness > 0) {
         startValue = endValue