Skip to content

Commit e7ed0b1

Browse files
robhoganchrfalch
authored andcommitted
[LOCAL] Backout #46896 - Attempt to fix #50274 (#52515)
1 parent be73538 commit e7ed0b1

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,14 +1403,14 @@ private void detachRootViewFromInstance(ReactRoot reactRoot, ReactContext reactC
14031403
new RuntimeException(
14041404
"detachRootViewFromInstance called with ReactRootView with invalid id"));
14051405
}
1406-
1407-
clearReactRoot(reactRoot);
14081406
} else {
14091407
reactContext
14101408
.getCatalystInstance()
14111409
.getJSModule(AppRegistry.class)
14121410
.unmountApplicationComponentAtRootTag(reactRoot.getRootViewTag());
14131411
}
1412+
1413+
clearReactRoot(reactRoot);
14141414
}
14151415

14161416
@ThreadConfined(UI)

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -679,9 +679,6 @@ public synchronized void removeRootView(int rootViewTag) {
679679
View rootView = mTagsToViews.get(rootViewTag);
680680
dropView(rootView);
681681
mRootTags.delete(rootViewTag);
682-
if (rootView != null) {
683-
rootView.setId(View.NO_ID);
684-
}
685682
}
686683

687684
/**

0 commit comments

Comments
 (0)