Add tests for DisplayMetricsHolder - #52946
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
cortinico
force-pushed
the
export-D78981753
branch
from
August 1, 2025 13:50
ce7fe38 to
f3da3aa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
cortinico
force-pushed
the
export-D78981753
branch
from
August 1, 2025 13:56
f3da3aa to
b97ac45
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
cortinico
force-pushed
the
export-D78981753
branch
from
August 4, 2025 09:26
b97ac45 to
92979f3
Compare
Summary: There is currently a bug with Modals with New Architecture where the first frame is rendered incorrectly, specifically not accounting for all the vertical insets (only the status bar). This fixes it. ## Changelog: [ANDROID] [FIXED] - Correctly account for insets on first render of Modals on New Arch Pull Request resolved: react#52835 Test Plan: See internal CI Differential Revision: D78975126 Pulled By: cortinico
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
cortinico
force-pushed
the
export-D78981753
branch
from
August 7, 2025 14:37
92979f3 to
8ba8c03
Compare
Summary: Pull Request resolved: react#52946 This just add a set of unit tests for `DisplayMetricsHolder` as I'm working on this class recently. Changelog: [Internal] [Changed] - Reviewed By: rshest, mdvacca Differential Revision: D78981753
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78981753 |
cortinico
force-pushed
the
export-D78981753
branch
from
August 7, 2025 16:03
8ba8c03 to
fd356a0
Compare
Contributor
|
This pull request has been merged in 384677f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This just add a set of unit tests for
DisplayMetricsHolderas I'm working on this class recently.Changelog:
[Internal] [Changed] -
Reviewed By: rshest
Differential Revision: D78981753