Skip to content

Improve codegen to add getDebugProps to components - #53135

Closed
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D79805145
Closed

Improve codegen to add getDebugProps to components#53135
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D79805145

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Summary:
Our Codegenerated components are not generating code for getDebugProps. This change modifies Codegen to add those functions for all the codegen components.

Changelog:

[General][Added] - Added getDebugProps to codegen

Differential Revision: D79805145

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2025
@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 2 times, most recently from 8578a0f to 877ad3b Compare August 7, 2025 17:08
@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 2 times, most recently from f873a44 to 806f644 Compare August 7, 2025 17:44
@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 2 times, most recently from 061a4ae to f106f65 Compare August 7, 2025 18:04
@facebook-github-bot

facebook-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 3 times, most recently from 8a15c99 to 92ca9a5 Compare August 8, 2025 09:46
@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 2 times, most recently from 2195fb6 to 3f164a2 Compare August 8, 2025 10:22
@cipolleschi
cipolleschi force-pushed the export-D79805145 branch 2 times, most recently from e07bc67 to e5b9525 Compare August 8, 2025 10:48
@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@cipolleschi @facebook-github-bot
Improve codegen to add getDebugProps to components (#53135)
528451f 
Summary:
Pull Request resolved: #53135

Our Codegenerated components are not generating code for `getDebugProps`. This change modifies Codegen to add those functions for all the codegen components.

## Changelog:
[General][Added] - Added getDebugProps to codegen

## Facebook:
`getDebugProps` are required by Fantom to write tests. However, we can't generate these function for third party components, because codegen can generate arbitrary structs and we don't have a generic `toString()` method that can be used or automatically generated by C++.

By generating this function only for Core Components, we can ensure that we can write Fantom tests without breaking all the users of React Native.

Reviewed By: rubennorte

Differential Revision: D79805145
@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D79805145

@facebook-github-bot

facebook-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request has been merged in e547f46.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 8, 2025
@react-native-bot

react-native-bot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in e547f46

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cipolleschi @facebook-github-bot @react-native-bot