Fix transformOrigin conversion ignoring unit type - #54092
Closed
lenaic wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Summary: The `transformOrigin` conversion didn't call into the `toDynamic` conversion for the underlying `ValueUnit` instances for the x and y coordinates. This diff fixes the conversion so that percentages would be correctly converted. Changelog: [Internal] Differential Revision: D84165034
lenaic
force-pushed
the
export-D84165034
branch
from
October 8, 2025 16:39
eb2db9e to
bfe753c
Compare
|
This pull request has been merged in 9afd6bb. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 9afd6bb When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
transformOriginconversion didn't call into thetoDynamicconversion for the underlyingValueUnitinstances for the x and y coordinates. This diff fixes the conversion so that percentages would be correctly converted.Changelog: [Internal]
Differential Revision: D84165034