Fix EXC_BAD_ACCESS for animated - #54158
Closed
andrewdacenko wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [Internal] Animated was capturing `self` directly in C++ std::function contexts. When capturing Objective-C objects in C++ lambdas, they aren't automatically retained. When these lambdas were invoked later (potentially after `self` was deallocated), accessing `_onRender` and other instance variables caused the crash. Reviewed By: zeyap Differential Revision: D84638972
meta-cla
Bot
added
the
CLA Signed
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84638972. |
|
This pull request has been merged in e79920c. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in e79920c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Animated was capturing
selfdirectly in C++ std::function contexts. When capturing Objective-C objects in C++ lambdas, they aren't automatically retained. When these lambdas were invoked later (potentially afterselfwas deallocated), accessing_onRenderand other instance variables caused the crash.Reviewed By: zeyap
Differential Revision: D84638972