Remove custom header support from DevSupportHttpClient - #55884
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95059080. |
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 09:45
398cd18 to
0ea2b4f
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: react#55884 The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 09:49
0ea2b4f to
6cd3450
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: react#55884 The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
2 times, most recently
from
March 4, 2026 10:34
5964ae1 to
082f30a
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 14:42
082f30a to
7bf86e7
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 14:46
7bf86e7 to
fc8de87
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: react#55884 The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 4, 2026
Summary: Pull Request resolved: react#55884 The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 14:54
fc8de87 to
7299d01
Compare
Summary: All 7 callers of DevSupportHttpClient are within ReactAndroid, so there is no need to expose it as a public API. Make the class and all its members internal. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95059038
Summary: The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport. Instead we can use the `setOkHttpClientFactory` to provide this same logic. Changelog: [Internal] Reviewed By: javache, cipolleschi Differential Revision: D95059080
cortinico
force-pushed
the
export-D95059080
branch
from
March 4, 2026 15:39
7299d01 to
a227949
Compare
|
This pull request has been merged in 3f46e5f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.
Instead we can use the
setOkHttpClientFactoryto provide this same logic.Changelog: [Internal]
Differential Revision: D95059080