Convert YogaConfigJNIFinalizer and YogaNodeJNIFinalizer to Kotlin - #56021
Closed
andrewdacenko wants to merge 1 commit into
Closed
Convert YogaConfigJNIFinalizer and YogaNodeJNIFinalizer to Kotlin#56021andrewdacenko wants to merge 1 commit into
andrewdacenko wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95872345. |
andrewdacenko
force-pushed
the
export-D95872345
branch
from
March 10, 2026 22:09
f5982b1 to
be26f87
Compare
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
Mar 10, 2026
…act#56021) Summary: X-link: react/yoga#1915 Pull Request resolved: react#56021 Changelog: [Internal] Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes. Changes: - Convert `YogaConfigJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Convert `YogaNodeJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Remove `super.finalize()` calls (no-op in parent chain, and `Object.finalize()` is not directly callable from Kotlin) The `:yoga` Buck target already has `language = "KOTLIN"` and globs both `*.java` and `*.kt`, so no build config changes are needed. Differential Revision: D95872345
andrewdacenko
added a commit
to andrewdacenko/yoga
that referenced
this pull request
Mar 10, 2026
…act#1915) Summary: Pull Request resolved: react#1915 X-link: react/react-native#56021 Changelog: [Internal] Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes. Changes: - Convert `YogaConfigJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Convert `YogaNodeJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Remove `super.finalize()` calls (no-op in parent chain, and `Object.finalize()` is not directly callable from Kotlin) The `:yoga` Buck target already has `language = "KOTLIN"` and globs both `*.java` and `*.kt`, so no build config changes are needed. Differential Revision: D95872345
andrewdacenko
added a commit
to andrewdacenko/yoga
that referenced
this pull request
Mar 10, 2026
…act#1915) Summary: Pull Request resolved: react#1915 X-link: react/react-native#56021 Changelog: [Internal] Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes. Changes: - Convert `YogaConfigJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Convert `YogaNodeJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Remove `super.finalize()` calls (no-op in parent chain, and `Object.finalize()` is not directly callable from Kotlin) The `:yoga` Buck target already has `language = "KOTLIN"` and globs both `*.java` and `*.kt`, so no build config changes are needed. Differential Revision: D95872345
cortinico
approved these changes
Mar 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…act#56021) Summary: X-link: react/yoga#1915 Pull Request resolved: react#56021 Changelog: [Internal] Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes. Changes: - Convert `YogaConfigJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Convert `YogaNodeJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Remove `super.finalize()` calls (no-op in parent chain, and `Object.finalize()` is not directly callable from Kotlin) The `:yoga` Buck target already has `language = "KOTLIN"` and globs both `*.java` and `*.kt`, so no build config changes are needed. Reviewed By: cortinico Differential Revision: D95872345
andrewdacenko
force-pushed
the
export-D95872345
branch
from
March 10, 2026 22:21
be26f87 to
021d37b
Compare
|
This pull request has been merged in 63800af. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in 63800af When will my fix make it into a release? | How to file a pick request? |
meta-codesync Bot
pushed a commit
to react/yoga
that referenced
this pull request
Mar 11, 2026
) Summary: Pull Request resolved: #1915 X-link: react/react-native#56021 Changelog: [Internal] Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes. Changes: - Convert `YogaConfigJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Convert `YogaNodeJNIFinalizer.java` → `.kt` (ReactAndroid + xplat/yoga copies) - Remove `super.finalize()` calls (no-op in parent chain, and `Object.finalize()` is not directly callable from Kotlin) The `:yoga` Buck target already has `language = "KOTLIN"` and globs both `*.java` and `*.kt`, so no build config changes are needed. Reviewed By: cortinico Differential Revision: D95872345 fbshipit-source-id: 371d0eee8874f3436e41d8d5ba6083ce174c0f18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Convert the last two Java finalizer classes in the yoga package to Kotlin, continuing the React Native Kotlinification effort. Both classes are simple JNI native memory cleanup wrappers (32 and 36 lines) that extend already-Kotlin base classes.
Changes:
YogaConfigJNIFinalizer.java→.kt(ReactAndroid + xplat/yoga copies)YogaNodeJNIFinalizer.java→.kt(ReactAndroid + xplat/yoga copies)super.finalize()calls (no-op in parent chain, andObject.finalize()is not directly callable from Kotlin)The
:yogaBuck target already haslanguage = "KOTLIN"and globs both*.javaand*.kt, so no build config changes are needed.Differential Revision: D95872345