IApiResponse.EnsureSuccessStatusCodeAsync

[eben-roux]

I may just be missing something, but I'm looking to throw an exception when a call to an IApiResponse endpoint fails (not IApiResponse<T>).

I did come across this in ApiResponseExtensions:

        public ValueTask<IApiResponse<T>> EnsureSuccessStatusCodeAsync()
        {
            var checkedResponse = response ?? throw new ArgumentNullException(nameof(response));
            return checkedResponse.IsSuccessStatusCode
                ? new(checkedResponse)
                : new(Task.FromException<IApiResponse<T>>(GetError(checkedResponse)));
        }

Could the same extension method be added for IApiResponse?

[glennawatson]

Good catch - the non-generic IApiResponse is missing the success-guard that IApiResponse<T> already has (EnsureSuccessStatusCodeAsync / EnsureSuccessfulAsync). It is a small, symmetric addition - the internal GetError already accepts the non-generic type - so I have opened #2241 to track it with a full spec. Let's continue there. Thanks!