Skip to content

Commit 91097dc

Browse files
authored
Revise Hermes release branch naming conventions (#1231)
Updated instructions for creating Hermes release branches and patch number bumping.
1 parent 1c17ab6 commit 91097dc

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

docs/guide-hermes-release.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ We decoupled the build of Hermes from the React Native repository and we can now
2020
### Step 1: Check-out or create the (Legacy) Hermes release branch
2121

2222
#### If you are cutting a release candidate
23-
Create a Hermes release branch of the form `rn/<major>.<minor>-stable` from latest `main`.
23+
Create a Hermes release branch of the form `release-v0.<hermes-minor>` from latest `main`.
2424

2525
Make sure your branch is pushed to the remote.
2626

2727
```
2828
# Run this in the Hermes repo:
2929
git checkout main
3030
git pull origin main
31-
git checkout -b rn/0.76-stable
31+
git checkout -b release-v0.14
3232
git push origin HEAD
3333
```
3434

@@ -62,9 +62,13 @@ This workflow:
6262

6363
The tag will be created as last step, and we need to wait for the whole process to end before React Native can start the Release.
6464

65+
> [!Important]
66+
> If you are releasing a patch for legacy Hermes, you also have to bump the patch number [`hermes-compiler/package.json`](https://github.com/facebook/hermes/blob/release-v0.14/npm/hermes-compiler/package.json#L3) file from the `release-v0.XX` branch.
67+
> If you are releasing a patch for Hermes V1 for the latest version of React Native, you also have to bump the patch number [`hermes-compiler/package.json`](https://github.com/facebook/hermes/blob/250829098.0.0-stable/npm/hermes-compiler/package.json#L3) file from the `250829098.0.0-stable`
68+
6569
#### For (Legacy) Hermes
6670

67-
1. Set the branch to the release branch (e.g.: rn/0.83-stable)
71+
1. Set the branch to the release branch (e.g.: `release-v0.14`)
6872
2. Set the release type as `Release`
6973

7074
#### For Hermes V1

0 commit comments

Comments
 (0)