fix(achievements): gate Original Visionary on computed scores (#141)

Author: redxzeta

apps/web/src/components/chat/environment/EnvironmentOriginalityMeterSection.test.tsx

@@ -2,7 +2,10 @@ import type { GitOriginalityMeterResult } from "@forkara/contracts";
 import { renderToStaticMarkup } from "react-dom/server";
 import { describe, expect, it } from "vitest";
 
-import { OriginalityMeterReport } from "./EnvironmentOriginalityMeterSection";
+import {
+  isComputedOriginalityResult,
+  OriginalityMeterReport,
+} from "./EnvironmentOriginalityMeterSection";
 
 function result(overrides: Partial<GitOriginalityMeterResult> = {}): GitOriginalityMeterResult {
   return {
@@ -71,3 +74,27 @@ describe("OriginalityMeterReport", () => {
     expect(html).toContain("Upstream history may apply");
   });
 });
+
+describe("isComputedOriginalityResult", () => {
+  it.each([0, 25, 100])("accepts a genuine computed %i%% result", (scorePercent) => {
+    expect(isComputedOriginalityResult(result({ scorePercent }))).toBe(true);
+  });
+
+  it.each(["missing_upstream", "incomplete_history", "unrelated_history"] as const)(
+    "rejects the %s provenance state",
+    (state) => {
+      expect(isComputedOriginalityResult(result({ state, scorePercent: null }))).toBe(false);
+    },
+  );
+
+  it("rejects loading and read-error paths that have no result", () => {
+    expect(isComputedOriginalityResult(undefined)).toBe(false);
+    expect(isComputedOriginalityResult(null)).toBe(false);
+  });
+
+  it("fails closed for malformed ready scores", () => {
+    expect(isComputedOriginalityResult(result({ scorePercent: Number.NaN }))).toBe(false);
+    expect(isComputedOriginalityResult(result({ scorePercent: -1 }))).toBe(false);
+    expect(isComputedOriginalityResult(result({ scorePercent: 101 }))).toBe(false);
+  });
+});

apps/web/src/components/chat/environment/EnvironmentOriginalityMeterSection.tsx

@@ -41,8 +41,20 @@ function unavailableTitle(state: GitOriginalityMeterResult["state"]): string {
   }
 }
 
+export function isComputedOriginalityResult(
+  result: GitOriginalityMeterResult | null | undefined,
+): boolean {
+  return (
+    result?.state === "ready" &&
+    typeof result.scorePercent === "number" &&
+    Number.isFinite(result.scorePercent) &&
+    result.scorePercent >= 0 &&
+    result.scorePercent <= 100
+  );
+}
+
 export function OriginalityMeterReport({ result }: { result: GitOriginalityMeterResult }) {
-  const available = result.state === "ready" && result.scorePercent !== null;
+  const available = isComputedOriginalityResult(result);
   const certification = originalityCertification(result);
   return (
     <div className="space-y-4">
@@ -162,7 +174,7 @@ export function EnvironmentOriginalityMeterSection({
     ...GIT_EXPENSIVE_READ_RETRY_OPTIONS,
   });
   useEffect(() => {
-    if (originalityQuery.data) {
+    if (isComputedOriginalityResult(originalityQuery.data)) {
       recordAchievementEvent({ type: "originality_meter.result" });
     }
   }, [originalityQuery.data]);