Check Matching Restrictions in Domains.py

[George-D-S]

In https://github.com/renalreg/ukrdc-cupid/blob/main/src/ukrdc_cupid/core/audit/domain.py

There are functions such as def address_matched(session): which contain code like -

            PatientRecord.sendingextract == "UKRDC",
            PatientRecord.pid != PatientRecordAlias.pid,
            PatientRecord.ukrdcid != PatientRecordAlias.ukrdcid,

These require that one half of the comparison is a UKRDC record, but don't care about the type of the other kind (i.e. no check on PatientRecordAlias.sendingextract).

Is this intentional?

[philmain28]

Yes.

It's been a while since I wrote this but it was meant to be an experiment in how you might generate workitems on domain data rather than incoming data. The idea with this specific bit of code being to flag if there are discrepancies between rda data and data from other sources. in something like linking ukrdcid by other means for patients that have slipped through the net for review by humans.

This is not fundamental to the operation of cupid.