ResultItem - Review Key Logic

[George-D-S]

ukrdc-cupid/src/ukrdc_cupid/core/store/keygen.py

Line 52 in c702375

def generate_key_resultitem(xml, order_id: int, seq_no: int) -> str:

This needs more of a comment, perhaps just copying the one from the Java code of...

// TNG-470 - If prepost is "PRE" set the relevant key section as ""
//           This means that if "" comes through first, followed by "PRE" they will both get the same key
//           and the PRE entry replaces the "" entry.
//           The actual data is not changed though so the prepost field is whatever actually comes in from the sender

Although I think I know what the intent is here, I'm not sure it works - or not in all scenarios.

I would also have thought it could also apply to Observations as well - assuming it worked.

[philmain28]

Once cupid has gone live might it be worth having a more general think about how the keys work. For example, you could imagine logic which mirrors the pid and ukrdcid sequences to generate numeric keys which are matched on the attributes which are currently part of the compound key.