[CAP-9048] support named-parameter (object) input for task runs (#296)

Supports named-parameter (object) input for task runs (invocation and display). This has been supported via the API and SDK for some time, but not (well) in the CLI.

GitOrigin-RevId: 01e3f5d9733a379dcc592aaa34b6f305a8d4d1da

Author: blue-keleher

pkg/taskrun/details.go

@@ -30,6 +30,11 @@ func TaskRunDetailsFormat(taskRun *wfclient.TaskRunDetails) []tui.KeyValue {
 		{Key: "Completed At", Value: completedAt},
 	}
 
+	inputJSON, err := json.Marshal(taskRun.Input)
+	if err == nil {
+		keyValues = append(keyValues, tui.KeyValue{Key: "Input", Value: string(inputJSON)})
+	}
+
 	if taskRun.Error != nil {
 		keyValues = append(keyValues, tui.KeyValue{Key: "Error", Value: *taskRun.Error})
 	}

pkg/tasks/repo.go

@@ -16,15 +16,10 @@ type Repo struct {
 	client *client.ClientWithResponses
 }
 
-func (r *Repo) RunTask(ctx context.Context, taskID string, input []interface{}) (*workflows.TaskRun, error) {
-	var taskData workflows.TaskData
-	if err := taskData.FromTaskData0(input); err != nil {
-		return nil, fmt.Errorf("failed to convert input to TaskData: %w", err)
-	}
-
+func (r *Repo) RunTask(ctx context.Context, taskID string, input *workflows.TaskData) (*workflows.TaskRun, error) {
 	resp, err := r.client.CreateTaskWithResponse(ctx, client.CreateTaskJSONRequestBody{
 		Task:  taskID,
-		Input: taskData,
+		Input: *input,
 	})
 
 	if err != nil {

pkg/text/string.go

@@ -1,6 +1,7 @@
 package text
 
 import (
+	"encoding/json"
 	"fmt"
 
 	"github.com/render-oss/cli/pkg/client"
@@ -46,6 +47,12 @@ func Version(workflowID string) func(wfv *wfclient.WorkflowVersion) string {
 }
 
 func TaskRunDetails(taskRun *wfclient.TaskRunDetails) string {
+	inputStr := ""
+	inputJSON, err := json.Marshal(taskRun.Input)
+	if err == nil {
+		inputStr = fmt.Sprintf(",\ninput: %s", string(inputJSON))
+	}
+
 	errorOrResults := ""
 	if taskRun.Results != nil {
 		errorOrResults = fmt.Sprintf(",\nresults: %v", taskRun.Results)
@@ -54,6 +61,6 @@ func TaskRunDetails(taskRun *wfclient.TaskRunDetails) string {
 	}
 
 	return FormatStringF(
-		"Task run details for %s: status %s, started at %s, completed at %s%s",
-		taskRun.Id, taskRun.Status, taskRun.StartedAt, taskRun.CompletedAt, errorOrResults)
+		"Task run details for %s: status %s, started at %s, completed at %s%s%s",
+		taskRun.Id, taskRun.Status, taskRun.StartedAt, taskRun.CompletedAt, inputStr, errorOrResults)
 }

pkg/tui/views/workflows/loader.go

@@ -3,10 +3,7 @@ package workflows
 import (
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
-	"io"
-	"strings"
 	"time"
 
 	"github.com/render-oss/cli/pkg/client"
@@ -49,43 +46,39 @@ func (t *WorkflowLoader) CreateTaskRun(ctx context.Context, input TaskRunInput)
 	return t.taskRepo.RunTask(ctx, input.TaskID, inputData)
 }
 
-func unmarshalInputData(input string) ([]interface{}, error) {
-	var parsedInputs []interface{}
-
+func unmarshalInputData(input string) (*workflows.TaskData, error) {
 	if len(input) == 0 {
 		return nil, fmt.Errorf("Task input is required.")
 	}
 
 	inputRaw := []byte(input)
 
-	if err := json.Unmarshal(inputRaw, &parsedInputs); err != nil {
-		var syntaxErr *json.SyntaxError
-		var unmarshaltypeErr *json.UnmarshalTypeError
-		if errors.As(err, &syntaxErr) || errors.Is(err, io.ErrUnexpectedEOF) {
-			return nil, fmt.Errorf("The task input has invalid JSON.")
-		} else if errors.As(err, &unmarshaltypeErr) {
-			actualType := friendlyTypeName(unmarshaltypeErr.Value)
-			return nil, fmt.Errorf("Expected type array for task input, received type %s.", actualType)
-		} else {
-			return nil, err
-		}
+	// Validate that the input is valid JSON
+	if !json.Valid(inputRaw) {
+		return nil, fmt.Errorf("The task input has invalid JSON.")
 	}
 
-	return parsedInputs, nil
-}
+	var taskData workflows.TaskData
 
-// friendlyTypeName converts type names from Go's json.UnmarshalTypeError to user-friendly names
-func friendlyTypeName(typeName string) string {
-	typeName = strings.TrimSpace(typeName)
+	// Try to parse as array (TaskData0 contains positional arguments)
+	var arrayInput workflows.TaskData0
+	if err := json.Unmarshal(inputRaw, &arrayInput); err == nil {
+		if err := taskData.FromTaskData0(arrayInput); err != nil {
+			return nil, fmt.Errorf("failed to convert input to TaskData: %w", err)
+		}
+		return &taskData, nil
+	}
 
-	switch typeName {
-	case "[]interface {}":
-		return "array"
-	case "bool":
-		return "boolean"
-	default:
-		return typeName
+	// Try to parse as object (TaskData1 contains named parameters)
+	var objectInput workflows.TaskData1
+	if err := json.Unmarshal(inputRaw, &objectInput); err == nil {
+		if err := taskData.FromTaskData1(objectInput); err != nil {
+			return nil, fmt.Errorf("failed to convert input to TaskData: %w", err)
+		}
+		return &taskData, nil
 	}
+
+	return nil, fmt.Errorf("Task input must be a JSON array or object.")
 }
 
 func (w *WorkflowLoader) LoadVersionList(ctx context.Context, input VersionListInput, cur client.Cursor) (client.Cursor, []*wfclient.WorkflowVersion, error) {