forked from oomol-lab/open-connector
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathguarded-websocket.test.ts
More file actions
296 lines (262 loc) · 10.4 KB
/
Copy pathguarded-websocket.test.ts
File metadata and controls
296 lines (262 loc) · 10.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
import type { GuardedFetchDnsLookup, ResolvedAddress } from "./guarded-fetch.ts";
import type { GuardedWebSocketFailure, WebSocketConstructor } from "./guarded-websocket.ts";
import { describe, expect, it, vi } from "vitest";
import { openGuardedWebSocket } from "./guarded-websocket.ts";
type Listener = (event: unknown) => void;
class FakeSocket {
static opened: FakeSocket[] = [];
readonly url: string;
closed = false;
private readonly listeners = new Map<string, Listener[]>();
constructor(url: string) {
this.url = url;
FakeSocket.opened.push(this);
}
send(): void {}
close(): void {
this.closed = true;
}
addEventListener(type: string, listener: Listener): void {
const existing = this.listeners.get(type);
if (existing) {
existing.push(listener);
return;
}
this.listeners.set(type, [listener]);
}
emit(type: string, event: unknown = {}): void {
for (const listener of this.listeners.get(type) ?? []) {
listener(event);
}
}
}
/** Constructor that reports the socket back so the test can drive its events. */
function fakeConstructor(onCreate?: (socket: FakeSocket) => void): WebSocketConstructor {
return function FakeWebSocket(url: string) {
const socket = new FakeSocket(url);
// Open on the next tick so the caller has attached its handshake listeners.
globalThis.setTimeout(() => onCreate?.(socket), 0);
return socket;
} as unknown as WebSocketConstructor;
}
/** Constructor whose sockets open immediately after listeners are attached. */
function openingConstructor(): WebSocketConstructor {
return fakeConstructor((socket) => socket.emit("open"));
}
function lookupTable(entries: Record<string, ResolvedAddress[]>): GuardedFetchDnsLookup {
return async (hostname: string) => {
const result = entries[hostname];
if (!result) {
throw new Error(`no lookup entry for ${hostname}`);
}
return result;
};
}
/** Records which failure kind the guard reported, so tests assert on the kind and not only the message. */
interface FailureRecorder {
createFailure: (kind: GuardedWebSocketFailure, message: string) => Error;
kinds: GuardedWebSocketFailure[];
}
function failureKinds(): FailureRecorder {
const kinds: GuardedWebSocketFailure[] = [];
return {
createFailure: (kind, message) => {
kinds.push(kind);
return new Error(message);
},
kinds,
};
}
describe("openGuardedWebSocket URL guard", () => {
it("rejects a literal loopback target before constructing a socket", async () => {
FakeSocket.opened = [];
await expect(
openGuardedWebSocket("ws://127.0.0.1:8123/api/websocket", { webSocketConstructor: openingConstructor() }),
).rejects.toThrow(/private or reserved IP addresses/);
expect(FakeSocket.opened).toHaveLength(0);
});
it("rejects a cloud metadata target", async () => {
await expect(
openGuardedWebSocket("ws://169.254.169.254/api/websocket", { webSocketConstructor: openingConstructor() }),
).rejects.toThrow(/private or reserved IP addresses/);
});
it("rejects a hostname that resolves into a private range", async () => {
FakeSocket.opened = [];
await expect(
openGuardedWebSocket("ws://homeassistant.example.com/api/websocket", {
webSocketConstructor: openingConstructor(),
lookup: lookupTable({ "homeassistant.example.com": [{ address: "192.168.1.10", family: 4 }] }),
}),
).rejects.toThrow(/must not resolve to private or reserved IP addresses/);
expect(FakeSocket.opened).toHaveLength(0);
});
it("allows a private-resolving hostname when private network access is opted in", async () => {
const socket = await openGuardedWebSocket("ws://homeassistant.example.com/api/websocket", {
webSocketConstructor: openingConstructor(),
allowPrivateNetwork: true,
lookup: lookupTable({ "homeassistant.example.com": [{ address: "192.168.1.10", family: 4 }] }),
});
expect(socket).toBeInstanceOf(FakeSocket);
});
it("re-evaluates a function-valued private network flag on every call", async () => {
let allowed = false;
const options = {
webSocketConstructor: openingConstructor(),
allowPrivateNetwork: (): boolean => allowed,
lookup: lookupTable({ "ha.example.com": [{ address: "10.0.0.5", family: 4 }] }),
};
await expect(openGuardedWebSocket("ws://ha.example.com/api/websocket", options)).rejects.toThrow(
/must not resolve to private/,
);
allowed = true;
await expect(openGuardedWebSocket("ws://ha.example.com/api/websocket", options)).resolves.toBeInstanceOf(
FakeSocket,
);
});
it("fails closed when the lookup cannot resolve the hostname", async () => {
await expect(
openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: openingConstructor(),
lookup: lookupTable({}),
}),
).rejects.toThrow(/could not be resolved for validation/);
});
it("skips resolved-address validation when skipDnsValidation is set", async () => {
await expect(
openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: openingConstructor(),
skipDnsValidation: true,
lookup: lookupTable({}),
}),
).resolves.toBeInstanceOf(FakeSocket);
});
it("rejects a non-http scheme", async () => {
await expect(
openGuardedWebSocket("ftp://ha.example.com/api/websocket", { webSocketConstructor: openingConstructor() }),
).rejects.toThrow(/must use http or https/);
});
it("uses the caller's guard error factory and field name", async () => {
class GuardError extends Error {}
await expect(
openGuardedWebSocket("ws://127.0.0.1/api/websocket", {
webSocketConstructor: openingConstructor(),
createError: (message) => new GuardError(message),
fieldName: "Home Assistant base URL",
}),
).rejects.toThrow(/^Home Assistant base URL/);
});
});
describe("openGuardedWebSocket scheme mapping", () => {
it("connects over wss when the validated URL is https", async () => {
FakeSocket.opened = [];
await openGuardedWebSocket("https://ha.example.com/api/websocket", {
webSocketConstructor: openingConstructor(),
});
expect(FakeSocket.opened[0]?.url).toBe("wss://ha.example.com/api/websocket");
});
it("connects over ws when the validated URL is http", async () => {
FakeSocket.opened = [];
await openGuardedWebSocket("http://ha.example.com:8123/api/websocket", {
webSocketConstructor: openingConstructor(),
});
expect(FakeSocket.opened[0]?.url).toBe("ws://ha.example.com:8123/api/websocket");
});
it("preserves a wss input and its query string", async () => {
FakeSocket.opened = [];
await openGuardedWebSocket("wss://ha.example.com/api/websocket?v=1", {
webSocketConstructor: openingConstructor(),
});
expect(FakeSocket.opened[0]?.url).toBe("wss://ha.example.com/api/websocket?v=1");
});
it("normalizes the hostname before connecting", async () => {
FakeSocket.opened = [];
await openGuardedWebSocket("wss://HA.Example.COM./api/websocket", {
webSocketConstructor: openingConstructor(),
});
expect(FakeSocket.opened[0]?.url).toBe("wss://ha.example.com/api/websocket");
});
});
describe("openGuardedWebSocket failures", () => {
it("reports an unsupported runtime when the global constructor is missing", async () => {
const { createFailure, kinds } = failureKinds();
vi.stubGlobal("WebSocket", undefined);
try {
await expect(openGuardedWebSocket("wss://ha.example.com/api/websocket", { createFailure })).rejects.toThrow(
/WebSocket is unavailable in this runtime/,
);
} finally {
vi.unstubAllGlobals();
}
expect(kinds).toEqual(["unsupported"]);
});
it("falls back to the global constructor when none is injected", async () => {
const created: string[] = [];
vi.stubGlobal(
"WebSocket",
fakeConstructor((socket) => {
created.push(socket.url);
socket.emit("open");
}),
);
try {
await expect(openGuardedWebSocket("wss://ha.example.com/api/websocket")).resolves.toBeInstanceOf(FakeSocket);
} finally {
vi.unstubAllGlobals();
}
expect(created).toEqual(["wss://ha.example.com/api/websocket"]);
});
it("reports a connect failure when the socket errors before opening", async () => {
const { createFailure, kinds } = failureKinds();
await expect(
openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: fakeConstructor((socket) => socket.emit("error")),
createFailure,
}),
).rejects.toThrow(/WebSocket connection failed/);
expect(kinds).toEqual(["connect"]);
});
it("reports a connect failure when the peer closes before opening", async () => {
const { createFailure, kinds } = failureKinds();
await expect(
openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: fakeConstructor((socket) => socket.emit("close", { code: 1006 })),
createFailure,
}),
).rejects.toThrow(/closed before the connection opened/);
expect(kinds).toEqual(["connect"]);
});
it("times out and closes a socket that never opens", async () => {
const { createFailure, kinds } = failureKinds();
FakeSocket.opened = [];
await expect(
openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: fakeConstructor(),
connectTimeoutMs: 5,
createFailure,
}),
).rejects.toThrow(/timed out/);
expect(kinds).toEqual(["timeout"]);
expect(FakeSocket.opened[0]?.closed).toBe(true);
});
it("aborts a pending connection when the signal fires", async () => {
const controller = new AbortController();
const pending = openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: fakeConstructor(),
signal: controller.signal,
});
controller.abort();
await expect(pending).rejects.toThrow(/aborted/);
});
it("ignores a late close event after the socket opened", async () => {
let opened: FakeSocket | undefined;
const socket = await openGuardedWebSocket("wss://ha.example.com/api/websocket", {
webSocketConstructor: fakeConstructor((created) => {
opened = created;
created.emit("open");
}),
});
expect(socket).toBe(opened);
// Post-handshake events belong to the caller; they must not reject retroactively.
expect(() => opened?.emit("close", { code: 1000 })).not.toThrow();
});
});