Skip to content

Commit 09482e5

Browse files
res-lifeChong Gaoclaude
authored
Add Spark 3.5.9 support for CreateNamedStruct shims (NVIDIA#15388)
### Description `CreateNamedStructShims` and `GpuCreateNamedStructSuite` were introduced while Spark 3.5.9 support was being added, so their shim metadata omitted the `359` entry. As a result, common code in a Spark 3.5.9 build cannot resolve `CreateNamedStructShims`. This change adds the missing `{"spark": "359"}` entry to both files. Spark 3.5.9 now uses the same legacy `name.toString` behavior as the other Spark 3.5.x shims, and the existing `GpuCreateNamedStructSuite` runs for this build version. Validation: - `mvn -Dbuildver=359 -DskipTests -pl sql-plugin -am install` — `BUILD SUCCESS` - `mvn -Dbuildver=359 -pl sql-plugin test -Dsuffixes='.*GpuCreateNamedStructSuite'` — 1 test passed ### Checklists Documentation - [ ] Updated for new or modified user-facing features or behaviors - [x] No user-facing change Testing - [x] Added or modified tests to cover new code paths - [ ] Covered by existing tests - [ ] Not required Performance - [ ] Tests ran and results are added in the PR description - [ ] Issue filed with a link in the PR description - [x] Not required Co-authored-by: Chong Gao <res_life@163.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 391e34f commit 09482e5

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

sql-plugin/src/main/spark330/scala/org/apache/spark/sql/rapids/shims/CreateNamedStructShims.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
{"spark": "356"}
3838
{"spark": "357"}
3939
{"spark": "358"}
40+
{"spark": "359"}
4041
{"spark": "400"}
4142
{"spark": "400db173"}
4243
{"spark": "401"}

sql-plugin/src/test/spark330/scala/org/apache/spark/sql/rapids/GpuCreateNamedStructSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
{"spark": "356"}
3838
{"spark": "357"}
3939
{"spark": "358"}
40+
{"spark": "359"}
4041
{"spark": "400"}
4142
{"spark": "400db173"}
4243
{"spark": "401"}

0 commit comments

Comments
 (0)