fix: clean up telemetry temp files on flush failure (#194)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Co-authored-by: Felipe Freitag Vargas <ffvargas@gmail.com>

Author: 3 people

src/lib/telemetry.ts

@@ -192,6 +192,9 @@ export async function flushFromFile(filePath: string): Promise<void> {
     closeSync(fd);
   }
 
-  await flushPayload(payload);
-  unlinkSync(resolved);
+  try {
+    await flushPayload(payload);
+  } finally {
+    unlinkSync(resolved);
+  }
 }

tests/lib/telemetry.test.ts

@@ -449,12 +449,12 @@ describe('flushFromFile', () => {
     }
   });
 
-  it('preserves file when flush fails', async () => {
+  it('deletes file even when flush fails', async () => {
     fetchSpy.mockResolvedValue({ ok: false, status: 500 } as Response);
     const payload = JSON.stringify({ event: 'test' });
     writeFileSync(tmpFile, payload);
 
     await expect(flushFromFile(tmpFile)).rejects.toThrow();
-    expect(existsSync(tmpFile)).toBe(true);
+    expect(existsSync(tmpFile)).toBe(false);
   });
 });